Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82088?usp=email )
(
5 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: acpi: Fix return value in acpi_device_write_dsd_gpio() ......................................................................
acpi: Fix return value in acpi_device_write_dsd_gpio()
Fix ++ as suffix and * precedence. After modification, the gpio index can be obtained correctly. The error was introduced in the commit making it public: commit 01344bce
BUG=None TEST= Can get the correct index test on nissa.
Change-Id: I7a3eb89633aaebebc8bd98ac6126c578fda23839 Signed-off-by: Jianeng Ceng cengjianeng@huaqin.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/82088 Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: Dolan Liu liuyong5@huaqin.corp-partner.google.com Reviewed-by: Kapil Porwal kapilporwal@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/acpi/device.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Kapil Porwal: Looks good to me, approved Eric Lai: Looks good to me, approved build bot (Jenkins): Verified Dolan Liu: Looks good to me, but someone else must approve
diff --git a/src/acpi/device.c b/src/acpi/device.c index 091a086..7313639 100644 --- a/src/acpi/device.c +++ b/src/acpi/device.c @@ -51,7 +51,7 @@ return ret;
acpi_device_write_gpio(gpio); - ret = *curr_index++; + ret = (*curr_index)++;
return ret; }