Subrata Banik submitted this change.

View Change



5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: Kapil Porwal: Looks good to me, approved Eric Lai: Looks good to me, approved build bot (Jenkins): Verified Dolan Liu: Looks good to me, but someone else must approve
acpi: Fix return value in acpi_device_write_dsd_gpio()

Fix ++ as suffix and * precedence. After modification, the gpio index
can be obtained correctly.
The error was introduced in the commit making it public:
commit 01344bce

BUG=None
TEST= Can get the correct index test on nissa.

Change-Id: I7a3eb89633aaebebc8bd98ac6126c578fda23839
Signed-off-by: Jianeng Ceng <cengjianeng@huaqin.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/82088
Reviewed-by: Eric Lai <ericllai@google.com>
Reviewed-by: Dolan Liu <liuyong5@huaqin.corp-partner.google.com>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/acpi/device.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/acpi/device.c b/src/acpi/device.c
index 091a086..7313639 100644
--- a/src/acpi/device.c
+++ b/src/acpi/device.c
@@ -51,7 +51,7 @@
return ret;

acpi_device_write_gpio(gpio);
- ret = *curr_index++;
+ ret = (*curr_index)++;

return ret;
}

To view, visit change 82088. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7a3eb89633aaebebc8bd98ac6126c578fda23839
Gerrit-Change-Number: 82088
Gerrit-PatchSet: 7
Gerrit-Owner: Jianeng Ceng <cengjianeng@huaqin.corp-partner.google.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang@intel.com>
Gerrit-Reviewer: Dolan Liu <liuyong5@huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai@google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao@gmail.com>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: merged