Change in coreboot[master]: Revert "device/pci_device.c: Do not complain about disabled devices"
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44078 )
Change subject: Revert "device/pci_device.c: Do not complain about disabled devices" ......................................................................
Revert "device/pci_device.c: Do not complain about disabled devices"
This reverts commit ad247ac5d8ef4a38bd1d61fbd28076f343a46c5c.
It doesn't work like this. The `dev->enable` field has already been updated and is always `0` at this point.
Change-Id: I5b3560dcea2f226c841f4823526db2fdab149d22 Signed-off-by: Nico Huber nico.huber@secunet.com --- M src/device/pci_device.c 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/44078/1
diff --git a/src/device/pci_device.c b/src/device/pci_device.c index f3cced9..3623c3b 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -1297,10 +1297,6 @@ /* Unlink it from list. */ *prev = dev->sibling;
- /* If disabled in devicetree, do not print any messages. */ - if (!dev->enabled) - continue; - if (!once++) printk(BIOS_WARNING, "PCI: Leftover static devices:\n"); printk(BIOS_WARNING, "%s\n", dev_path(dev));
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44078 )
Change subject: Revert "device/pci_device.c: Do not complain about disabled devices" ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44078/1/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/44078/1/src/device/pci_device.c@128... PS1, Line 1280: /* : * Warn if any leftover static devices are are found. : * There's probably a problem in devicetree.cb. : */ : : prev = &bus->children; : for (dev = bus->children; dev; dev = dev->sibling) { : /* : * The device is only considered leftover if it is not hidden : * and it has a Vendor ID of 0 (the default for a device that : * could not be probed). : */ : if (dev->vendor != 0 || dev->hidden) { : prev = &dev->sibling; : continue; : } : : /* Unlink it from list. */ : *prev = dev->sibling; : : if (!once++) : printk(BIOS_WARNING, "PCI: Leftover static devices:\n"); : printk(BIOS_WARNING, "%s\n", dev_path(dev)); : } : : if (once) : printk(BIOS_WARNING, "PCI: Check your devicetree.cb.\n"); Then this whole thing needs to be elsewhere, right?
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44078 )
Change subject: Revert "device/pci_device.c: Do not complain about disabled devices" ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44078/1/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/44078/1/src/device/pci_device.c@128... PS1, Line 1280: /* : * Warn if any leftover static devices are are found. : * There's probably a problem in devicetree.cb. : */ : : prev = &bus->children; : for (dev = bus->children; dev; dev = dev->sibling) { : /* : * The device is only considered leftover if it is not hidden : * and it has a Vendor ID of 0 (the default for a device that : * could not be probed). : */ : if (dev->vendor != 0 || dev->hidden) { : prev = &dev->sibling; : continue; : } : : /* Unlink it from list. */ : *prev = dev->sibling; : : if (!once++) : printk(BIOS_WARNING, "PCI: Leftover static devices:\n"); : printk(BIOS_WARNING, "%s\n", dev_path(dev)); : } : : if (once) : printk(BIOS_WARNING, "PCI: Check your devicetree.cb.\n");
Then this whole thing needs to be elsewhere, right?
I don't know.
Marking as resolved, because the question is unrelated.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44078 )
Change subject: Revert "device/pci_device.c: Do not complain about disabled devices" ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Without this revert, the error printing code is dead. With it, it needlessly scares people. I don't know what's worse.
https://review.coreboot.org/c/coreboot/+/44078/1/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/44078/1/src/device/pci_device.c@128... PS1, Line 1280: /* : * Warn if any leftover static devices are are found. : * There's probably a problem in devicetree.cb. : */ : : prev = &bus->children; : for (dev = bus->children; dev; dev = dev->sibling) { : /* : * The device is only considered leftover if it is not hidden : * and it has a Vendor ID of 0 (the default for a device that : * could not be probed). : */ : if (dev->vendor != 0 || dev->hidden) { : prev = &dev->sibling; : continue; : } : : /* Unlink it from list. */ : *prev = dev->sibling; : : if (!once++) : printk(BIOS_WARNING, "PCI: Leftover static devices:\n"); : printk(BIOS_WARNING, "%s\n", dev_path(dev)); : } : : if (once) : printk(BIOS_WARNING, "PCI: Check your devicetree.cb.\n");
I don't know. […]
This thing actually does two things, so the question isn't yes/no.
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44078 )
Change subject: Revert "device/pci_device.c: Do not complain about disabled devices" ......................................................................
Revert "device/pci_device.c: Do not complain about disabled devices"
This reverts commit ad247ac5d8ef4a38bd1d61fbd28076f343a46c5c.
It doesn't work like this. The `dev->enable` field has already been updated and is always `0` at this point.
Change-Id: I5b3560dcea2f226c841f4823526db2fdab149d22 Signed-off-by: Nico Huber nico.huber@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44078 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/device/pci_device.c 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/device/pci_device.c b/src/device/pci_device.c index f3cced9..3623c3b 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -1297,10 +1297,6 @@ /* Unlink it from list. */ *prev = dev->sibling;
- /* If disabled in devicetree, do not print any messages. */ - if (!dev->enabled) - continue; - if (!once++) printk(BIOS_WARNING, "PCI: Leftover static devices:\n"); printk(BIOS_WARNING, "%s\n", dev_path(dev));
-
Angel Pons (Code Review) -
Nico Huber (Code Review)