Without this revert, the error printing code is dead. With it, it needlessly scares people. I don't know what's worse.
Patch set 1:Code-Review +2
1 comment:
/*
* Warn if any leftover static devices are are found.
* There's probably a problem in devicetree.cb.
*/
prev = &bus->children;
for (dev = bus->children; dev; dev = dev->sibling) {
/*
* The device is only considered leftover if it is not hidden
* and it has a Vendor ID of 0 (the default for a device that
* could not be probed).
*/
if (dev->vendor != 0 || dev->hidden) {
prev = &dev->sibling;
continue;
}
/* Unlink it from list. */
*prev = dev->sibling;
if (!once++)
printk(BIOS_WARNING, "PCI: Leftover static devices:\n");
printk(BIOS_WARNING, "%s\n", dev_path(dev));
}
if (once)
printk(BIOS_WARNING, "PCI: Check your devicetree.cb.\n");
I don't know. […]
This thing actually does two things, so the question isn't yes/no.
To view, visit change 44078. To unsubscribe, or for help writing mail filters, visit settings.