Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44356 )
Change subject: mb/google/volteer: Define stop_gpio for goodix touch screen ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44356/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44356/1//COMMIT_MSG@11 PS1, Line 11: defins defines
https://review.coreboot.org/c/coreboot/+/44356/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44356/1/src/mainboard/google/voltee... PS1, Line 93: 120 have you tried 10ms here?
https://review.coreboot.org/c/coreboot/+/44356/1/src/mainboard/google/voltee... PS1, Line 98: 12 same, have you tried 10 here?
-
Tim Wawrzynczak (Code Review)