Change in coreboot[master]: util/amdfwtool: clean up Makefile, Makefile.inc

[Idwer Vollering (Code Review)]

Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49086 )

Change subject: util/amdfwtool: clean up Makefile, Makefile.inc
......................................................................

util/amdfwtool: clean up Makefile, Makefile.inc

Signed-off-by: Idwer Vollering 
Change-Id: Ia16af046acdc68c176b1c4ff434518a5f8f8bf9e
---
M util/amdfwtool/Makefile
M util/amdfwtool/Makefile.inc
2 files changed, 2 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/49086/1

diff --git a/util/amdfwtool/Makefile b/util/amdfwtool/Makefile
index 58606e3..00e6d59 100644
--- a/util/amdfwtool/Makefile
+++ b/util/amdfwtool/Makefile
@@ -9,7 +9,7 @@

$(TARGET): $(OBJ)
-	$(CC) $(OBJ) $(LDFLAGS) -o $@
+	$(CC) $(OBJ) -o $@

%.o: %.c $(HEADER)
    $(CC) $(CFLAGS) -c -o $@ $<
diff --git a/util/amdfwtool/Makefile.inc b/util/amdfwtool/Makefile.inc
index e794ed9..06a17f3 100644
--- a/util/amdfwtool/Makefile.inc
+++ b/util/amdfwtool/Makefile.inc
@@ -2,10 +2,8 @@

amdfwtoolobj = amdfwtool.o data_parse.o

-AMDFWTOOLCFLAGS=-O2 -Wall -Wextra -Wshadow
-
 $(objutil)/amdfwtool/%.o: $(top)/util/amdfwtool/%.c # $(HEADER)
-	$(HOSTCC) $(AMDFWTOOLCFLAGS) $(HOSTCFLAGS) -c -o $@ $<
+	$(HOSTCC) $(CFLAGS) -c -o $@ $<

$(objutil)/amdfwtool/amdfwtool: $(addprefix $(objutil)/amdfwtool/,$(amdfwtoolobj))
    printf "   AMDFWTOOL\n"

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49086 )

Change subject: util/amdfwtool: clean up Makefile, Makefile.inc
......................................................................

Patch Set 1: Code-Review+1

I'm unsure about the HOSTCFLAGS vs. CFLAGS change in Makefile.inc; would be good if someone who knows the design of the build system and the intention behind those things a bit better comments on this one.
The change in Makefile looks good to me.

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49086 )

Change subject: util/amdfwtool: clean up Makefile, Makefile.inc
......................................................................

Patch Set 1:

I don't understand any of the changes. And the commit message
does not reason about them.

Please note: coreboot's build system aside, it's generally
considered that the callee of `make` may override such
variables.

[Bao Zheng (Code Review)]

Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49086 )

Change subject: util/amdfwtool: clean up Makefile, Makefile.inc
......................................................................

Patch Set 1: Code-Review+1

[XS] Change in coreboot[master]: util/amdfwtool: clean up Makefile, Makefile.inc

[Martin L Roth (Code Review)]

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/49086?usp=email )

Change subject: util/amdfwtool: clean up Makefile, Makefile.inc
......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.