Change in coreboot[master]: Revert "src/Kconfig: enable USE_BLOBS by default"

[Nico Huber (Code Review)]

Hello Julius Werner, Angel Pons, Felix Held,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/c/coreboot/+/41848

to review the following change.


Change subject: Revert "src/Kconfig: enable USE_BLOBS by default"
......................................................................

Revert "src/Kconfig: enable USE_BLOBS by default"

This reverts commit a6b887e017f2310db79067b18b216036907b2d90.

It was brought to my attention that the 3rdparty/blobs/ repository
is full of licenses that don't adhere to our binary policy (that
demands unlimited redistribution rights). IANAL, but if the license
texts apply literally, it is not allowed to clone the blobs
repository without reading and agreeing to them.

Change-Id: I7079e23481eb96d1140f2fa5bc1abe7bd4b2bac8
Signed-off-by: Nico Huber <[e-mail]>
---
M src/Kconfig
M util/abuild/abuild
2 files changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/41848/1

diff --git a/src/Kconfig b/src/Kconfig
index 2a2a144..6a748db 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -214,7 +214,6 @@
 
 config USE_BLOBS
 	bool "Allow use of binary-only repository"
-	default y
 	help
 	  This draws in the blobs repository, which contains binary files that
 	  might be required for some chipsets or boards.
diff --git a/util/abuild/abuild b/util/abuild/abuild
index b6a6bfe..4d5ba35 100755
--- a/util/abuild/abuild
+++ b/util/abuild/abuild
@@ -715,7 +715,7 @@
 			shift;;
 		-B|--blobs)	shift
 			customizing="${customizing}, blobs"
-			configoptions="${configoptions}CONFIG_USE_AMD_BLOBS=y\nCONFIG_ADD_FSP_BINARIES=y\n"
+			configoptions="${configoptions}CONFIG_USE_BLOBS=y\nCONFIG_USE_AMD_BLOBS=y\nCONFIG_ADD_FSP_BINARIES=y\n"
 			;;
 		-A|--any-toolchain)	shift
 			customizing="${customizing}, any-toolchain"

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/41848
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7079e23481eb96d1140f2fa5bc1abe7bd4b2bac8
Gerrit-Change-Number: 41848
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Felix Held <[e-mail]>
Gerrit-Reviewer: Julius Werner <[e-mail]>
Gerrit-MessageType: newchange

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41848 )

Change subject: Revert "src/Kconfig: enable USE_BLOBS by default"
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/41848
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7079e23481eb96d1140f2fa5bc1abe7bd4b2bac8
Gerrit-Change-Number: 41848
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Felix Held <[e-mail]>
Gerrit-Reviewer: Julius Werner <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Fri, 29 May 2020 09:58:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41848 )

Change subject: Revert "src/Kconfig: enable USE_BLOBS by default"
......................................................................


Patch Set 1:

Alternatively, relocate the offending blobs to /dev/null and then delete all boards that cannot be built without them? Or maybe try to bargain a better license? I suck at communicating but I do have the patience and energy to pester people >:)


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/41848
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7079e23481eb96d1140f2fa5bc1abe7bd4b2bac8
Gerrit-Change-Number: 41848
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Felix Held <[e-mail]>
Gerrit-Reviewer: Julius Werner <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Fri, 29 May 2020 10:01:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41848 )

Change subject: Revert "src/Kconfig: enable USE_BLOBS by default"
......................................................................


Patch Set 1:
> Patch Set 1:
> Or maybe try to bargain a better license?

We will have to look into clearing up licensing for redistribution, with /dev/null as secondary option.
The distribution requirement follows from us providing the binaries through coreboot.org and github.com. While it could be argued that there's some implicit license for distribution via coreboot.org arising out of the vendor pushing the stuff to coreboot.org, I'm not sure if that automatically translates to redistribution to github.com and to the whole internet from there.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/41848
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7079e23481eb96d1140f2fa5bc1abe7bd4b2bac8
Gerrit-Change-Number: 41848
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Felix Held <[e-mail]>
Gerrit-Reviewer: Julius Werner <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-CC: Stefan Reinauer <[e-mail]>
Gerrit-CC: Werner Zeh <[e-mail]>
Gerrit-Comment-Date: Fri, 29 May 2020 10:35:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41848 )

Change subject: Revert "src/Kconfig: enable USE_BLOBS by default"
......................................................................


Patch Set 1:
> > Or maybe try to bargain a better license?
>
> We will have to look into clearing up licensing for redistribution, with /dev/null as secondary option.

I was thinking we could move the current `3rdparty/blobs`
to something like `3rdparty/limited_blobs` or `3rdparty/
restrictive_blobs`. And guard it like the `amd_blobs`.
Then move anything without doubts about redistribution
to a new `3rdparty/blobs`.
> The distribution requirement follows from us providing the binaries through coreboot.org and github.com. While it could be argued that there's some implicit license for distribution via coreboot.org arising out of the vendor pushing the stuff to coreboot.org, I'm not sure if that automatically translates to redistribution to github.com and to the whole internet from there.

That's exactly my thinking. The AMD licenses in the
old repo, for instance, explicitly put distribution
and sublicesing under their EULA. In my interpretation
that means anyone who downloads from coreboot.org can
only further distribute it under the EULA and not the
full license. They don't mention *re*distribution at
all btw.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/41848
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7079e23481eb96d1140f2fa5bc1abe7bd4b2bac8
Gerrit-Change-Number: 41848
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Felix Held <[e-mail]>
Gerrit-Reviewer: Julius Werner <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-CC: Stefan Reinauer <[e-mail]>
Gerrit-CC: Werner Zeh <[e-mail]>
Gerrit-Comment-Date: Fri, 29 May 2020 13:36:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Nico Huber (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Angel Pons, Julius Werner, Felix Held, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/41848

to look at the new patch set (#2).

Change subject: Revert "src/Kconfig: enable USE_BLOBS by default"
......................................................................

Revert "src/Kconfig: enable USE_BLOBS by default"

This reverts commit a6b887e017f2310db79067b18b216036907b2d90.

It was brought to my attention that the 3rdparty/blobs/ repository
is full of licenses that don't adhere to our binary policy (that
demands unlimited redistribution rights). IANAL, but if the license
texts apply literally, it is not allowed to clone the blobs
repository without reading and agreeing to them.

Change-Id: I7079e23481eb96d1140f2fa5bc1abe7bd4b2bac8
Signed-off-by: Nico Huber <[e-mail]>
---
M src/Kconfig
M util/abuild/abuild
2 files changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/41848/2
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/41848
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7079e23481eb96d1140f2fa5bc1abe7bd4b2bac8
Gerrit-Change-Number: 41848
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Felix Held <[e-mail]>
Gerrit-Reviewer: Julius Werner <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-CC: Stefan Reinauer <[e-mail]>
Gerrit-CC: Werner Zeh <[e-mail]>
Gerrit-MessageType: newpatchset

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41848 )

Change subject: Revert "src/Kconfig: enable USE_BLOBS by default"
......................................................................


Patch Set 2:

Rebased this as the problem didn't solve itself.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/41848
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7079e23481eb96d1140f2fa5bc1abe7bd4b2bac8
Gerrit-Change-Number: 41848
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Felix Held <[e-mail]>
Gerrit-Reviewer: Julius Werner <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-CC: Stefan Reinauer <[e-mail]>
Gerrit-CC: Werner Zeh <[e-mail]>
Gerrit-Comment-Date: Tue, 29 Dec 2020 02:18:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41848 )

Change subject: Revert "src/Kconfig: enable USE_BLOBS by default"
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/41848
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7079e23481eb96d1140f2fa5bc1abe7bd4b2bac8
Gerrit-Change-Number: 41848
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Felix Held <[e-mail]>
Gerrit-Reviewer: Julius Werner <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-CC: Stefan Reinauer <[e-mail]>
Gerrit-CC: Werner Zeh <[e-mail]>
Gerrit-Comment-Date: Thu, 31 Dec 2020 23:57:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[XS] Change in coreboot[master]: Revert "src/Kconfig: enable USE_BLOBS by default"

[Martin L Roth (Code Review)]

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41848?usp=email )

Change subject: Revert "src/Kconfig: enable USE_BLOBS by default"
......................................................................


Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/41848?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7079e23481eb96d1140f2fa5bc1abe7bd4b2bac8
Gerrit-Change-Number: 41848
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Felix Held <[e-mail]>
Gerrit-Reviewer: Julius Werner <[e-mail]>
Gerrit-Reviewer: Martin L Roth <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-CC: Stefan Reinauer <[e-mail]>
Gerrit-CC: Werner Zeh <[e-mail]>
Gerrit-MessageType: abandon