[M] Change in coreboot[main]: Choose Correct FW splash screen at runtime

[Subrata Banik (Code Review)]

Attention is currently required from: Andrey Petrov, Paul Menzel, Ronak Kanabar, Shelley Chen.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79775?usp=email )

Change subject: Choose Correct FW splash screen at runtime
......................................................................

Patch Set 8:

(11 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/79775/comment/baa8bb79_ec0a3c83 :
PS8, Line 7: Choose Correct FW splash screen at runtime
> correct

Acknowledged

https://review.coreboot.org/c/coreboot/+/79775/comment/e707dc18_c6b36e0c :
PS8, Line 7: Choose Correct FW splash screen at runtime
> It’d be great if you rephrased, as it seems ChromeOS specific?

Acknowledged

https://review.coreboot.org/c/coreboot/+/79775/comment/64f0f3c4_8a12c9b2 :
PS8, Line 16: CB_
> Fair point, maybe better to rename all those things to "CHROMEOS" to avoid ambiguity.

Acknowledged

https://review.coreboot.org/c/coreboot/+/79775/comment/3b31a52d_a97a5de7 :
PS8, Line 15:     CHROMEOS_FW_SPLASH_SCREEN
            :     CB_LOGO_PATH
            :     CB_PLUS_LOGO_PATH
> Please mark it up as a list.

Acknowledged

File src/include/bootsplash.h:

https://review.coreboot.org/c/coreboot/+/79775/comment/4abff182_1326151c :
PS8, Line 19: Allow platform-specific BMP logo overrides via
            :  * HAVE_CUSTOM_BMP_LOGO config.
            :  * For example: Introduce configurable BMP logo for
            :  * customization on platforms like ChromeOS
> Please use the fully allowed text width.

Acknowledged

https://review.coreboot.org/c/coreboot/+/79775/comment/6788f4a9_9ec52358 :
PS8, Line 24: get_bmp_file
> nit: Since this is now an exported function I think it should start with `bmp_` for cleaner namespac […]

Acknowledged

File src/vendorcode/google/chromeos/Kconfig:

https://review.coreboot.org/c/coreboot/+/79775/comment/f729b241_088122b2 :
PS8, Line 83: Firmware
> firmware

Acknowledged

https://review.coreboot.org/c/coreboot/+/79775/comment/1ec1f4f7_26e89f6d :
PS8, Line 88: to
> nit: typo?

Acknowledged

https://review.coreboot.org/c/coreboot/+/79775/comment/b5f827f5_c8b0624b :
PS8, Line 89: an
> nit: typo?

Acknowledged

https://review.coreboot.org/c/coreboot/+/79775/comment/801ce83c_9fa0575b :
PS8, Line 95: Logo
> logo

Acknowledged

https://review.coreboot.org/c/coreboot/+/79775/comment/33d6adc1_8dc41c4a :
PS8, Line 100: Logo
> logo

Acknowledged