Attention is currently required from: Andrey Petrov, Paul Menzel, Ronak Kanabar, Shelley Chen.
11 comments:
Commit Message:
Patch Set #8, Line 7: Choose Correct FW splash screen at runtime
correct
Acknowledged
Patch Set #8, Line 7: Choose Correct FW splash screen at runtime
It’d be great if you rephrased, as it seems ChromeOS specific?
Acknowledged
Fair point, maybe better to rename all those things to "CHROMEOS" to avoid ambiguity.
Acknowledged
CHROMEOS_FW_SPLASH_SCREEN
CB_LOGO_PATH
CB_PLUS_LOGO_PATH
Please mark it up as a list.
Acknowledged
File src/include/bootsplash.h:
Allow platform-specific BMP logo overrides via
* HAVE_CUSTOM_BMP_LOGO config.
* For example: Introduce configurable BMP logo for
* customization on platforms like ChromeOS
Please use the fully allowed text width.
Acknowledged
Patch Set #8, Line 24: get_bmp_file
nit: Since this is now an exported function I think it should start with `bmp_` for cleaner namespac […]
Acknowledged
File src/vendorcode/google/chromeos/Kconfig:
Patch Set #8, Line 83: Firmware
firmware
Acknowledged
nit: typo?
Acknowledged
nit: typo?
Acknowledged
logo
Acknowledged
logo
Acknowledged
To view, visit change 79775. To unsubscribe, or for help writing mail filters, visit settings.