Change in coreboot[master]: mb/up/squared: set primary GPU in the devicetree

[Maxim Polyakov (Code Review)]

Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39375 )

Change subject: mb/up/squared: set primary GPU in the devicetree
......................................................................

mb/up/squared: set primary GPU in the devicetree

Change-Id: I368fa5d13615dc4ee37db596cb6a5eef993fc220
Signed-off-by: Maxim Polyakov 
---
M src/mainboard/up/squared/devicetree.cb
M src/mainboard/up/squared/romstage.c
2 files changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/39375/1

diff --git a/src/mainboard/up/squared/devicetree.cb b/src/mainboard/up/squared/devicetree.cb
index d7281a6..6ba3bf4 100644
--- a/src/mainboard/up/squared/devicetree.cb
+++ b/src/mainboard/up/squared/devicetree.cb
@@ -1,5 +1,8 @@
 chip soc/intel/apollolake

+	# Set IGD as the primary graphics device
+	register "primary_gpu" = "PRIMARY_IGD"
+
    # Override USB port configuration
    register "usb_config_override" = "1"
    # USB 2.0
diff --git a/src/mainboard/up/squared/romstage.c b/src/mainboard/up/squared/romstage.c
index 55235a8..fd06559 100644
--- a/src/mainboard/up/squared/romstage.c
+++ b/src/mainboard/up/squared/romstage.c
@@ -169,7 +169,6 @@
    config->RmtCheckRun = 0x3;		// 0x0
    config->RmtMarginCheckScaleHighThreshold = 0xC8;	// 0x0
    config->EnhancePort8xhDecoding = 0x0;	// 0x1
-	config->PrimaryVideoAdaptor = 0x2;	// 0x0

config->Ch0_DeviceWidth = 0x1;		// 0x0
    config->Ch0_Option = 0x3;		// 0x0

Change in coreboot[master]: mb/up/squared: remove FSP option to set primary GPU

[Maxim Polyakov (Code Review)]

Hello  Felix Singer, build bot (Jenkins), Patrick Georgi, Paul Menzel, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39375

to look at the new patch set (#2).

Change subject: mb/up/squared: remove FSP option to set primary GPU
......................................................................

mb/up/squared: remove FSP option to set primary GPU

There is no need to set the FSP option to select the primary graphics
device in the board configuration, as it has already been done in the
soc initialization code [1].

[1] https://review.coreboot.org/c/coreboot/+/39374

Change-Id: I368fa5d13615dc4ee37db596cb6a5eef993fc220
Signed-off-by: Maxim Polyakov 
---
M src/mainboard/up/squared/romstage.c
1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/39375/2

Change in coreboot[master]: mb/up/squared: remove FSP option to set primary GPU

[Maxim Polyakov (Code Review)]

Hello  Felix Singer, build bot (Jenkins), Patrick Georgi, Paul Menzel, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39375

to look at the new patch set (#3).

Change subject: mb/up/squared: remove FSP option to set primary GPU
......................................................................

mb/up/squared: remove FSP option to set primary GPU

There is no need to set the FSP option to select the primary graphics
device in the board configuration, as it has already been done in the
soc initialization code [1].

[1] https://review.coreboot.org/c/coreboot/+/39374

Change-Id: I368fa5d13615dc4ee37db596cb6a5eef993fc220
Signed-off-by: Maxim Polyakov 
---
M src/mainboard/up/squared/romstage.c
1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/39375/3

Change in coreboot[master]: mb/up/squared: Undo set primary GPU via FSP option

[Maxim Polyakov (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Paul Menzel, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39375

to look at the new patch set (#12).

Change subject: mb/up/squared: Undo set primary GPU via FSP option
......................................................................

mb/up/squared: Undo set primary GPU via FSP option

This is no longer needed, since now this parameter is already set using
the ONBOARD_VGA_IS_PRIMARY config [1].

[1] https://review.coreboot.org/c/coreboot/+/39374

Change-Id: I368fa5d13615dc4ee37db596cb6a5eef993fc220
Signed-off-by: Maxim Polyakov 
---
M src/mainboard/up/squared/romstage.c
1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/39375/12

Change in coreboot[master]: mb/up/squared: Undo set primary GPU via FSP option

[Nico Huber (Code Review)]

Attention is currently required from: Maxim Polyakov.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39375 )

Change subject: mb/up/squared: Undo set primary GPU via FSP option
......................................................................

Patch Set 15: Code-Review+2

Change in coreboot[master]: mb/up/squared: Undo set primary GPU via FSP option

[Angel Pons (Code Review)]

Attention is currently required from: Maxim Polyakov.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39375 )

Change subject: mb/up/squared: Undo set primary GPU via FSP option
......................................................................

Patch Set 15: Code-Review+2

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/39375/comment/34b6353f_a6696ddb 
PS15, Line 12: [1] https://review.coreboot.org/c/coreboot/+/39374
Replace with `commit 1a4496e79f21bef12efc8c6748264a8770266a27`?

Change in coreboot[master]: mb/up/squared: Undo set primary GPU via FSP option

[Maxim Polyakov (Code Review)]

Attention is currently required from: Maxim Polyakov.
Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Paul Menzel, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39375

to look at the new patch set (#16).

Change subject: mb/up/squared: Undo set primary GPU via FSP option
......................................................................

mb/up/squared: Undo set primary GPU via FSP option

This is no longer needed, since now this parameter is already set using
the ONBOARD_VGA_IS_PRIMARY config [1].

[1] commit 1a4496e79f21bef12efc8c6748264a8770266a27

Change-Id: I368fa5d13615dc4ee37db596cb6a5eef993fc220
Signed-off-by: Maxim Polyakov 
---
M src/mainboard/up/squared/romstage.c
1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/39375/16

Change in coreboot[master]: mb/up/squared: Undo set primary GPU via FSP option

[Maxim Polyakov (Code Review)]

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39375 )

Change subject: mb/up/squared: Undo set primary GPU via FSP option
......................................................................

Patch Set 16:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/39375/comment/af9608f3_96a31f08 
PS15, Line 12: [1] https://review.coreboot.org/c/coreboot/+/39374
> Replace with `commit 1a4496e79f21bef12efc8c6748264a8770266a27`?

Done

Change in coreboot[master]: mb/up/squared: Undo set primary GPU via FSP option

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39375 )

Change subject: mb/up/squared: Undo set primary GPU via FSP option
......................................................................

mb/up/squared: Undo set primary GPU via FSP option

This is no longer needed, since now this parameter is already set using
the ONBOARD_VGA_IS_PRIMARY config [1].

[1] commit 1a4496e79f21bef12efc8c6748264a8770266a27

Change-Id: I368fa5d13615dc4ee37db596cb6a5eef993fc220
Signed-off-by: Maxim Polyakov 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39375
Tested-by: build bot (Jenkins) 
Reviewed-by: Nico Huber 
Reviewed-by: Angel Pons 
---
M src/mainboard/up/squared/romstage.c
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/up/squared/romstage.c b/src/mainboard/up/squared/romstage.c
index a7dc0a1..12e4135 100644
--- a/src/mainboard/up/squared/romstage.c
+++ b/src/mainboard/up/squared/romstage.c
@@ -168,7 +168,6 @@
    config->RmtCheckRun = 0x3;		// 0x0
    config->RmtMarginCheckScaleHighThreshold = 0xC8;	// 0x0
    config->EnhancePort8xhDecoding = 0x0;	// 0x1
-	config->PrimaryVideoAdaptor = 0x2;	// 0x0

config->Ch0_DeviceWidth = 0x1;		// 0x0
    config->Ch0_Option = 0x3;		// 0x0

15 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.