Angel Pons submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved
mb/up/squared: Undo set primary GPU via FSP option

This is no longer needed, since now this parameter is already set using
the ONBOARD_VGA_IS_PRIMARY config [1].

[1] commit 1a4496e79f21bef12efc8c6748264a8770266a27

Change-Id: I368fa5d13615dc4ee37db596cb6a5eef993fc220
Signed-off-by: Maxim Polyakov <max.senia.poliak@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39375
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M src/mainboard/up/squared/romstage.c
1 file changed, 0 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/up/squared/romstage.c b/src/mainboard/up/squared/romstage.c
index a7dc0a1..12e4135 100644
--- a/src/mainboard/up/squared/romstage.c
+++ b/src/mainboard/up/squared/romstage.c
@@ -168,7 +168,6 @@
config->RmtCheckRun = 0x3; // 0x0
config->RmtMarginCheckScaleHighThreshold = 0xC8; // 0x0
config->EnhancePort8xhDecoding = 0x0; // 0x1
- config->PrimaryVideoAdaptor = 0x2; // 0x0

config->Ch0_DeviceWidth = 0x1; // 0x0
config->Ch0_Option = 0x3; // 0x0

15 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.

To view, visit change 39375. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I368fa5d13615dc4ee37db596cb6a5eef993fc220
Gerrit-Change-Number: 39375
Gerrit-PatchSet: 17
Gerrit-Owner: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged