Change in coreboot[master]: soc/amd/picasso,stoneyridge: drop unused BIOSRAM offset defines
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48470 )
Change subject: soc/amd/picasso,stoneyridge: drop unused BIOSRAM offset defines ......................................................................
soc/amd/picasso,stoneyridge: drop unused BIOSRAM offset defines
The two Socs don't use this functionality and biosram.c in the common code is the only place where those defines are used, but it doesn't include soc/iomap.h and has its own definitions instead.
Change-Id: I973df4ab39a94e89ea2ed6ffb639c5a85b8df456 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/picasso/include/soc/iomap.h M src/soc/amd/stoneyridge/include/soc/iomap.h 2 files changed, 0 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/48470/1
diff --git a/src/soc/amd/picasso/include/soc/iomap.h b/src/soc/amd/picasso/include/soc/iomap.h index a49768f..cec3aaf 100644 --- a/src/soc/amd/picasso/include/soc/iomap.h +++ b/src/soc/amd/picasso/include/soc/iomap.h @@ -85,9 +85,4 @@ #define AB_DATA (AB_INDX+4) #define SYS_RESET 0xcf9
-/* BiosRam Ranges at 0xfed80500 or I/O 0xcd4/0xcd5 */ -#define BIOSRAM_CBMEM_TOP 0xf0 /* 4 bytes */ -#define BIOSRAM_UMA_SIZE 0xf4 /* 4 bytes */ -#define BIOSRAM_UMA_BASE 0xf8 /* 8 bytes */ - #endif /* AMD_PICASSO_IOMAP_H */ diff --git a/src/soc/amd/stoneyridge/include/soc/iomap.h b/src/soc/amd/stoneyridge/include/soc/iomap.h index 4328880..f39200f 100644 --- a/src/soc/amd/stoneyridge/include/soc/iomap.h +++ b/src/soc/amd/stoneyridge/include/soc/iomap.h @@ -46,9 +46,4 @@ #define AB_DATA (AB_INDX+4) #define SYS_RESET 0xcf9
-/* BiosRam Ranges at 0xfed80500 or I/O 0xcd4/0xcd5 */ -#define BIOSRAM_CBMEM_TOP 0xf0 /* 4 bytes */ -#define BIOSRAM_UMA_SIZE 0xf4 /* 4 bytes */ -#define BIOSRAM_UMA_BASE 0xf8 /* 8 bytes */ - #endif /* AMD_STONEYRIDGE_IOMAP_H */
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48470 )
Change subject: soc/amd/picasso,stoneyridge: drop unused BIOSRAM offset defines ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48470 )
Change subject: soc/amd/picasso,stoneyridge: drop unused BIOSRAM offset defines ......................................................................
soc/amd/picasso,stoneyridge: drop unused BIOSRAM offset defines
The two Socs don't use this functionality and biosram.c in the common code is the only place where those defines are used, but it doesn't include soc/iomap.h and has its own definitions instead.
Change-Id: I973df4ab39a94e89ea2ed6ffb639c5a85b8df456 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/48470 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/picasso/include/soc/iomap.h M src/soc/amd/stoneyridge/include/soc/iomap.h 2 files changed, 0 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/picasso/include/soc/iomap.h b/src/soc/amd/picasso/include/soc/iomap.h index a49768f..cec3aaf 100644 --- a/src/soc/amd/picasso/include/soc/iomap.h +++ b/src/soc/amd/picasso/include/soc/iomap.h @@ -85,9 +85,4 @@ #define AB_DATA (AB_INDX+4) #define SYS_RESET 0xcf9
-/* BiosRam Ranges at 0xfed80500 or I/O 0xcd4/0xcd5 */ -#define BIOSRAM_CBMEM_TOP 0xf0 /* 4 bytes */ -#define BIOSRAM_UMA_SIZE 0xf4 /* 4 bytes */ -#define BIOSRAM_UMA_BASE 0xf8 /* 8 bytes */ - #endif /* AMD_PICASSO_IOMAP_H */ diff --git a/src/soc/amd/stoneyridge/include/soc/iomap.h b/src/soc/amd/stoneyridge/include/soc/iomap.h index 4328880..f39200f 100644 --- a/src/soc/amd/stoneyridge/include/soc/iomap.h +++ b/src/soc/amd/stoneyridge/include/soc/iomap.h @@ -46,9 +46,4 @@ #define AB_DATA (AB_INDX+4) #define SYS_RESET 0xcf9
-/* BiosRam Ranges at 0xfed80500 or I/O 0xcd4/0xcd5 */ -#define BIOSRAM_CBMEM_TOP 0xf0 /* 4 bytes */ -#define BIOSRAM_UMA_SIZE 0xf4 /* 4 bytes */ -#define BIOSRAM_UMA_BASE 0xf8 /* 8 bytes */ - #endif /* AMD_STONEYRIDGE_IOMAP_H */
-
Felix Held (Code Review) -
Marshall Dawson (Code Review)