Daisuke Nojiri has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47144 )
Change subject: Atlas: Wake up AP on AC plug ......................................................................
Atlas: Wake up AP on AC plug
BUG=b:165328935 BRANCH=atlas TEST=emerge-atlas coreboot
Signed-off-by: Daisuke Nojiri dnojiri@chromium.org Change-Id: I95676d785bfc1488a8c1bdd3d56f2c38d95f3fb6 --- M src/mainboard/google/poppy/variants/atlas/include/variant/ec.h 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/47144/1
diff --git a/src/mainboard/google/poppy/variants/atlas/include/variant/ec.h b/src/mainboard/google/poppy/variants/atlas/include/variant/ec.h index 5e377f2..4caa734 100644 --- a/src/mainboard/google/poppy/variants/atlas/include/variant/ec.h +++ b/src/mainboard/google/poppy/variants/atlas/include/variant/ec.h @@ -37,7 +37,8 @@ */ #define MAINBOARD_EC_S3_WAKE_EVENTS \ (MAINBOARD_EC_S5_WAKE_EVENTS |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED)) + EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_CONNECTED))
#define MAINBOARD_EC_S0IX_WAKE_EVENTS (MAINBOARD_EC_S3_WAKE_EVENTS)
Daisuke Nojiri has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/47144 )
Change subject: Atlas: Wake up AP on AC plug and unplug ......................................................................
Atlas: Wake up AP on AC plug and unplug
This patch makes Atlas resume from S0ix by AC plug and unplug.
BUG=b:165328935 BRANCH=atlas TEST=Put Atlas in suspend. Wake it up by AC plug. TEST=Put Atlas in suspend. Wake it up by AC unplug.
Signed-off-by: Daisuke Nojiri dnojiri@chromium.org Change-Id: I95676d785bfc1488a8c1bdd3d56f2c38d95f3fb6 --- M 3rdparty/amd_blobs M 3rdparty/blobs M 3rdparty/intel-microcode M 3rdparty/qc_blobs M src/mainboard/google/poppy/variants/atlas/include/variant/ec.h 5 files changed, 9 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/47144/2
Daisuke Nojiri has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/47144 )
Change subject: Atlas: Wake up AP on AC plug and unplug ......................................................................
Atlas: Wake up AP on AC plug and unplug
This patch makes Atlas resume from S0ix by AC plug and unplug.
BUG=b:165328935 BRANCH=atlas TEST=Put Atlas in suspend. Wake it up by AC plug. TEST=Put Atlas in suspend. Wake it up by AC unplug.
Signed-off-by: Daisuke Nojiri dnojiri@chromium.org Change-Id: I95676d785bfc1488a8c1bdd3d56f2c38d95f3fb6 --- M src/mainboard/google/poppy/variants/atlas/include/variant/ec.h 1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/47144/3
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47144 )
Change subject: Atlas: Wake up AP on AC plug and unplug ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47144 )
Change subject: Atlas: Wake up AP on AC plug and unplug ......................................................................
Atlas: Wake up AP on AC plug and unplug
This patch makes Atlas resume from S0ix by AC plug and unplug.
BUG=b:165328935 BRANCH=atlas TEST=Put Atlas in suspend. Wake it up by AC plug. TEST=Put Atlas in suspend. Wake it up by AC unplug.
Signed-off-by: Daisuke Nojiri dnojiri@chromium.org Change-Id: I95676d785bfc1488a8c1bdd3d56f2c38d95f3fb6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/47144 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Caveh Jalali caveh@chromium.org --- M src/mainboard/google/poppy/variants/atlas/include/variant/ec.h 1 file changed, 5 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved
diff --git a/src/mainboard/google/poppy/variants/atlas/include/variant/ec.h b/src/mainboard/google/poppy/variants/atlas/include/variant/ec.h index 5e377f2..50afd42 100644 --- a/src/mainboard/google/poppy/variants/atlas/include/variant/ec.h +++ b/src/mainboard/google/poppy/variants/atlas/include/variant/ec.h @@ -32,12 +32,14 @@ EC_HOST_EVENT_MASK(EC_HOST_EVENT_POWER_BUTTON))
/* - * EC can wake from S3 with lid or power button or key press or - * mode change event. + * EC can wake from S3 with lid, power button, key press, + * mode change event, or AC plug/unplug. */ #define MAINBOARD_EC_S3_WAKE_EVENTS \ (MAINBOARD_EC_S5_WAKE_EVENTS |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED)) + EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_CONNECTED)|\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_DISCONNECTED))
#define MAINBOARD_EC_S0IX_WAKE_EVENTS (MAINBOARD_EC_S3_WAKE_EVENTS)
-
Caveh Jalali (Code Review) -
Daisuke Nojiri (Code Review)
-
Patrick Georgi (Code Review)