Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved
Atlas: Wake up AP on AC plug and unplug

This patch makes Atlas resume from S0ix by AC plug and unplug.

BUG=b:165328935
BRANCH=atlas
TEST=Put Atlas in suspend. Wake it up by AC plug.
TEST=Put Atlas in suspend. Wake it up by AC unplug.

Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Change-Id: I95676d785bfc1488a8c1bdd3d56f2c38d95f3fb6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47144
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Caveh Jalali <caveh@chromium.org>
---
M src/mainboard/google/poppy/variants/atlas/include/variant/ec.h
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/mainboard/google/poppy/variants/atlas/include/variant/ec.h b/src/mainboard/google/poppy/variants/atlas/include/variant/ec.h
index 5e377f2..50afd42 100644
--- a/src/mainboard/google/poppy/variants/atlas/include/variant/ec.h
+++ b/src/mainboard/google/poppy/variants/atlas/include/variant/ec.h
@@ -32,12 +32,14 @@
EC_HOST_EVENT_MASK(EC_HOST_EVENT_POWER_BUTTON))

/*
- * EC can wake from S3 with lid or power button or key press or
- * mode change event.
+ * EC can wake from S3 with lid, power button, key press,
+ * mode change event, or AC plug/unplug.
*/
#define MAINBOARD_EC_S3_WAKE_EVENTS \
(MAINBOARD_EC_S5_WAKE_EVENTS |\
- EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED))
+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\
+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_CONNECTED)|\
+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_DISCONNECTED))

#define MAINBOARD_EC_S0IX_WAKE_EVENTS (MAINBOARD_EC_S3_WAKE_EVENTS)


To view, visit change 47144. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95676d785bfc1488a8c1bdd3d56f2c38d95f3fb6
Gerrit-Change-Number: 47144
Gerrit-PatchSet: 4
Gerrit-Owner: Daisuke Nojiri <dnojiri@chromium.org>
Gerrit-Reviewer: Caveh Jalali <caveh@chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged