Attention is currently required from: Nico Huber, Michał Żygowski, Kacper Stojek, Paul Menzel, Lean Sheng Tan, Werner Zeh.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72404 )
Change subject: soc/intel/elkhartlake/romstage/fsp_params.c: separate debug params
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72404/comment/400d1bd4_0d267d7b
PS5, Line 9: eperates
typo: separates
https://review.coreboot.org/c/coreboot/+/72404/comment/124a6798_afea1e99
PS5, Line 14: Change-Id: I84f7c19a7c2fd5a4db18f5a37e1c667da017aace
'ommited' may be misspelled - perhaps 'omitted'?
Please fix.
File src/soc/intel/elkhartlake/chip.h:
https://review.coreboot.org/c/coreboot/+/72404/comment/f2dd4729_5ffcf013
PS5, Line 316: } isa_serial_uart_base;
Why is this in the devicetree?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72404
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I84f7c19a7c2fd5a4db18f5a37e1c667da017aace
Gerrit-Change-Number: 72404
Gerrit-PatchSet: 5
Gerrit-Owner: Kacper Stojek
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Kacper Stojek
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 21 Feb 2023 16:29:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment