Change in coreboot[master]: This implements the ACPI BERT.

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Lance Zhao, Francois Toguo Fotso, Martin Roth, Nikunj Dadhania, Tim Wawrzynczak, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49799 )

Change subject: This implements the ACPI BERT.
......................................................................

Patch Set 1:

(4 comments)

Patchset:

PS1: 
Can't you use src/arch/x86/acpi_bert_storage.c and the BERT infrastructure already in coreboot?

File src/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/49799/comment/082e707f_7cbe30ee 
PS1, Line 1227: void acpi_write_bert(acpi_bert_t *bert, uintptr_t region, size_t length)
Can this function be used instead?

https://review.coreboot.org/c/coreboot/+/49799/comment/637df3df_b7718b10 
PS1, Line 1342: /* Boot Error Record Table creation */
              : void acpi_create_bert(acpi_bert_t *bert)
              : {
              : 	acpi_header_t *header = &(bert->header);
              : 	if (!header)
              : 		return;
              : 
              : 	memset((void *) bert, 0, sizeof(acpi_bert_t));
              : 
              : 	memcpy(header->signature, "BERT", 4);
              : 	header->length = sizeof(acpi_bert_t);
              : 	header->revision = get_acpi_table_revision(BERT);
              : 	memcpy(header->oem_id, OEM_ID, 6);
              : 	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
              : 	memcpy(header->asl_compiler_id, ASLC, 4);
              : 	header->asl_compiler_revision = asl_revision;
              : 
              : 	acpi_soc_fill_bert(bert);
              : 
              : 	/* (Re)calculate length and checksum. */
              : 	header->checksum = acpi_checksum((void *)header, header->length);
              : }
This is 95% identical to `acpi_write_bert()` ~100 lines above this

File src/soc/intel/common/acpi_bert_storage.c:

PS1: 
I don't understand what this does differently than src/arch/x86/acpi_bert_storage.c?