Change in coreboot[master]: sb/intel/bd82x6x: Add missing ID for PCI bridge

[James (Code Review)]

James has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41015 )

Change subject: sb/intel/bd82x6x: Add missing ID for PCI bridge
......................................................................

sb/intel/bd82x6x: Add missing ID for PCI bridge

The PCI device ID 0x244e for the "Intel Corporation 82801 PCI Bridge"
was missing.

Change-Id: I22cdbcf518d86af7b93de7731d175088a81bbc1f
Signed-off-by: James Ye 
---
M src/southbridge/intel/bd82x6x/pci.c
1 file changed, 9 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/41015/1

diff --git a/src/southbridge/intel/bd82x6x/pci.c b/src/southbridge/intel/bd82x6x/pci.c
index 459ed46..757bdeb 100644
--- a/src/southbridge/intel/bd82x6x/pci.c
+++ b/src/southbridge/intel/bd82x6x/pci.c
@@ -58,8 +58,14 @@
    .ops_pci		= &pci_ops,
 };

+static const unsigned short pci_device_ids[] = {
+	0x244e, /* Desktop */
+	0x2448, /* Mobile */
+	0
+};
+
 static const struct pci_driver pch_pci __pci_driver = {
-	.ops	= &device_ops,
-	.vendor	= PCI_VENDOR_ID_INTEL,
-	.device	= 0x2448,
+	.ops		= &device_ops,
+	.vendor		= PCI_VENDOR_ID_INTEL,
+	.devices	= pci_device_ids,
 };

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41015 )

Change subject: sb/intel/bd82x6x: Add missing ID for PCI bridge
......................................................................

Patch Set 1: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41015 )

Change subject: sb/intel/bd82x6x: Add missing ID for PCI bridge
......................................................................

Patch Set 1: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/41015/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41015/1//COMMIT_MSG@11 
PS1, Line 11: 
Tested how?

https://review.coreboot.org/c/coreboot/+/41015/1/src/southbridge/intel/bd82x... 
File src/southbridge/intel/bd82x6x/pci.c:

https://review.coreboot.org/c/coreboot/+/41015/1/src/southbridge/intel/bd82x... 
PS1, Line 63: 	0x2448, /* Mobile */
Please order it according to the IDs.

[James Ye (Code Review)]

Hello build bot (Jenkins), Nico Huber, Paul Menzel, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41015

to look at the new patch set (#2).

Change subject: sb/intel/bd82x6x: Add missing ID for PCI bridge
......................................................................

sb/intel/bd82x6x: Add missing ID for PCI bridge

The PCI device ID 0x244e for the "Intel Corporation 82801 PCI Bridge"
for desktop platforms was missing.

Change-Id: I22cdbcf518d86af7b93de7731d175088a81bbc1f
Signed-off-by: James Ye 
---
M src/southbridge/intel/bd82x6x/pci.c
1 file changed, 9 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/41015/2

[James Ye (Code Review)]

Attention is currently required from: Paul Menzel.
James Ye has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41015 )

Change subject: sb/intel/bd82x6x: Add missing ID for PCI bridge
......................................................................

Patch Set 2:

(1 comment)

File src/southbridge/intel/bd82x6x/pci.c:

https://review.coreboot.org/c/coreboot/+/41015/comment/b855d967_e19d0325 
PS1, Line 63: 	0x2448, /* Mobile */
> Please order it according to the IDs.

Done

[Nico Huber (Code Review)]

Attention is currently required from: Paul Menzel, James Ye.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41015 )

Change subject: sb/intel/bd82x6x: Add missing ID for PCI bridge
......................................................................

Patch Set 2: Code-Review+2

[James (Code Review)]

Attention is currently required from: Paul Menzel.
James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41015 )

Change subject: sb/intel/bd82x6x: Add missing ID for PCI bridge
......................................................................

Patch Set 2:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/41015/comment/6e3a61dc_e0066a62 
PS1, Line 11:
> Tested how?

Tested on a modified config of mb/asus/p8z77-series, setting SDCDID on PECR3 for a root port (Intel 7 Series / C216 Chipset Family PCH Datasheet §20.1.53). PCI bridge initialisation confirmed via cbmem log.

Would you prefer I add this info to the commit message?

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41015 )

Change subject: sb/intel/bd82x6x: Add missing ID for PCI bridge
......................................................................

sb/intel/bd82x6x: Add missing ID for PCI bridge

The PCI device ID 0x244e for the "Intel Corporation 82801 PCI Bridge"
for desktop platforms was missing.

Change-Id: I22cdbcf518d86af7b93de7731d175088a81bbc1f
Signed-off-by: James Ye 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41015
Tested-by: build bot (Jenkins) 
Reviewed-by: Nico Huber 
---
M src/southbridge/intel/bd82x6x/pci.c
1 file changed, 9 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved

diff --git a/src/southbridge/intel/bd82x6x/pci.c b/src/southbridge/intel/bd82x6x/pci.c
index 895135b..da8208a 100644
--- a/src/southbridge/intel/bd82x6x/pci.c
+++ b/src/southbridge/intel/bd82x6x/pci.c
@@ -45,8 +45,14 @@
    .ops_pci		= &pci_dev_ops_pci,
 };

+static const unsigned short pci_device_ids[] = {
+	0x2448, /* Mobile */
+	0x244e, /* Desktop */
+	0
+};
+
 static const struct pci_driver pch_pci __pci_driver = {
-	.ops	= &device_ops,
-	.vendor	= PCI_VENDOR_ID_INTEL,
-	.device	= 0x2448,
+	.ops		= &device_ops,
+	.vendor		= PCI_VENDOR_ID_INTEL,
+	.devices	= pci_device_ids,
 };