Hello Felix Singer, Nico Huber, Arthur Heymans, Michael Niewöhner, Patrick Rudolph,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/48360
to review the following change.
Change subject: mb/intel/coffeelake_rvp/var/cfl_u: Add empty verb table ......................................................................
mb/intel/coffeelake_rvp/var/cfl_u: Add empty verb table
The code in soc/intel/common is rather messy, so there's no easy way to conditionally build a verb table with the changes that follow this one.
Change-Id: I00d968563539a4e1b8d1e12145293439d8358555 Signed-off-by: Angel Pons th3fanbus@gmail.com --- A src/mainboard/intel/coffeelake_rvp/variants/cfl_u/hda_verb.h 1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/48360/1
diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cfl_u/hda_verb.h b/src/mainboard/intel/coffeelake_rvp/variants/cfl_u/hda_verb.h new file mode 100644 index 0000000..d4c6273 --- /dev/null +++ b/src/mainboard/intel/coffeelake_rvp/variants/cfl_u/hda_verb.h @@ -0,0 +1,19 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef HDA_VERB_H +#define HDA_VERB_H + +#include <device/azalia_device.h> + +const u32 cim_verb_data[] = { + /* VerbTable: CFL Display Audio Codec */ + 0x8086280b, + 0xffffffff, + 0, +}; + +const u32 pc_beep_verbs[] = { +}; + +AZALIA_ARRAY_SIZES; +#endif
Hello Felix Singer, build bot (Jenkins), Nico Huber, Arthur Heymans, Michael Niewöhner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48360
to look at the new patch set (#2).
Change subject: mb/intel/coffeelake_rvp/var/cfl_u: Add empty verb table ......................................................................
mb/intel/coffeelake_rvp/var/cfl_u: Add empty verb table
The code in soc/intel/common is rather messy, so there's no easy way to conditionally build a verb table with the changes that follow this one.
Change-Id: I00d968563539a4e1b8d1e12145293439d8358555 Signed-off-by: Angel Pons th3fanbus@gmail.com --- A src/mainboard/intel/coffeelake_rvp/variants/cfl_u/include/variant/hda_verb.h 1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/48360/2
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48360 )
Change subject: mb/intel/coffeelake_rvp/var/cfl_u: Add empty verb table ......................................................................
Patch Set 2:
I'm not sure if it's a good idea to add empty headers just to "fix" the build
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48360 )
Change subject: mb/intel/coffeelake_rvp/var/cfl_u: Add empty verb table ......................................................................
Patch Set 2: Code-Review-1
Patch Set 2:
I'm not sure if it's a good idea to add empty headers just to "fix" the build
I agree. This is not really an improvement.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48360 )
Change subject: mb/intel/coffeelake_rvp/var/cfl_u: Add empty verb table ......................................................................
Patch Set 2:
Patch Set 2: Code-Review-1
Patch Set 2:
I'm not sure if it's a good idea to add empty headers just to "fix" the build
I agree. This is not really an improvement.
I could instead replace the headers with proper C files, which would also fix the problem I have.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48360 )
Change subject: mb/intel/coffeelake_rvp/var/cfl_u: Add empty verb table ......................................................................
Patch Set 2: -Code-Review
I could instead replace the headers with proper C files, which would also fix the problem I have.
Sounds good. Please do that.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48360 )
Change subject: mb/intel/coffeelake_rvp/var/cfl_u: Add empty verb table ......................................................................
Patch Set 2:
Patch Set 2: -Code-Review
I could instead replace the headers with proper C files, which would also fix the problem I have.
Sounds good. Please do that.
Empty c files instead of empty headers? How does that make a difference? The right way is to have no files when none are required -> fix the build system
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48360 )
Change subject: mb/intel/coffeelake_rvp/var/cfl_u: Add empty verb table ......................................................................
Patch Set 2:
Empty c files instead of empty headers? How does that make a difference? The right way is to have no files when none are required -> fix the build system
I don't think he meant replacing the header file by an empty C file.
#include "variant/hda_verb.h"
This is from mb/intel/coffeelake_rvp/hda_verb.c, which requires every variant to have such a header file. I think what he suggested was to move the hda_verb.c to the variant directories and add them to their Makefile.inc, if needed.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48360 )
Change subject: mb/intel/coffeelake_rvp/var/cfl_u: Add empty verb table ......................................................................
Patch Set 2:
Patch Set 2:
Empty c files instead of empty headers? How does that make a difference? The right way is to have no files when none are required -> fix the build system
I don't think he meant replacing the header file by an empty C file.
#include "variant/hda_verb.h"
This is from mb/intel/coffeelake_rvp/hda_verb.c, which requires every variant to have such a header file. I think what he suggested was to move the hda_verb.c to the variant directories and add them to their Makefile.inc, if needed.
That's not what I understood from the commit message tbh
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48360 )
Change subject: mb/intel/coffeelake_rvp/var/cfl_u: Add empty verb table ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Empty c files instead of empty headers? How does that make a difference? The right way is to have no files when none are required -> fix the build system
I don't think he meant replacing the header file by an empty C file.
#include "variant/hda_verb.h"
This is from mb/intel/coffeelake_rvp/hda_verb.c, which requires every variant to have such a header file. I think what he suggested was to move the hda_verb.c to the variant directories and add them to their Makefile.inc, if needed.
That's not what I understood from the commit message tbh
Angel, could you explain what exactly the change is trying to achieve - I must be missing something here
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48360 )
Change subject: mb/intel/coffeelake_rvp/var/cfl_u: Add empty verb table ......................................................................
Patch Set 2:
Patch Set 2:
Empty c files instead of empty headers? How does that make a difference? The right way is to have no files when none are required -> fix the build system
I don't think he meant replacing the header file by an empty C file.
#include "variant/hda_verb.h"
This is from mb/intel/coffeelake_rvp/hda_verb.c, which requires every variant to have such a header file. I think what he suggested was to move the hda_verb.c to the variant directories and add them to their Makefile.inc, if needed.
Yeah, I'm just going to remove `mb/intel/coffeelake_rvp/hda_verb.c` and convert all variant hda_verb.h into a hda_verb.c, then update the Makefile.inc path to build the variants' hda_verb.c instead.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48360 )
Change subject: mb/intel/coffeelake_rvp/var/cfl_u: Add empty verb table ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Patch Set 2:
Empty c files instead of empty headers? How does that make a difference? The right way is to have no files when none are required -> fix the build system
I don't think he meant replacing the header file by an empty C file.
#include "variant/hda_verb.h"
This is from mb/intel/coffeelake_rvp/hda_verb.c, which requires every variant to have such a header file. I think what he suggested was to move the hda_verb.c to the variant directories and add them to their Makefile.inc, if needed.
That's not what I understood from the commit message tbh
Angel, could you explain what exactly the change is trying to achieve - I must be missing something here
I fear you've mixed what this change does with the idea I had later on, and naturally ended up very confused. I'm going to scrap this change, and instead do what I just wrote in the reply to Felix (which does not involve adding any empty files; in fact, one file will be removed).
Hope this helps 😊
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48360 )
Change subject: mb/intel/coffeelake_rvp/var/cfl_u: Add empty verb table ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48360 )
Change subject: mb/intel/coffeelake_rvp/var/cfl_u: Add empty verb table ......................................................................
Patch Set 2: Code-Review-2
I can think of something better...
Hello Felix Singer, build bot (Jenkins), Nico Huber, Subrata Banik, Arthur Heymans, Michael Niewöhner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48360
to look at the new patch set (#3).
Change subject: mb/intel/coffeelake_rvp: Stop using headers for HDA verbs ......................................................................
mb/intel/coffeelake_rvp: Stop using headers for HDA verbs
One of the variants lacks an hda_verb.h, and hda_verb.c can't be built. Follow-up changes will make mainboard hda_verb.c files always get built through AZALIA_PLUGIN_SUPPORT, and breaks building this contraption.
Turn the headers into standalone compilation units to prevent this issue. Since they contain definitions, including them from multiple compilation units wasn't a good idea anyway.
Change-Id: I00d968563539a4e1b8d1e12145293439d8358555 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/intel/coffeelake_rvp/Makefile.inc D src/mainboard/intel/coffeelake_rvp/hda_verb.c R src/mainboard/intel/coffeelake_rvp/variants/cfl_h/hda_verb.c C src/mainboard/intel/coffeelake_rvp/variants/cfl_s/hda_verb.c D src/mainboard/intel/coffeelake_rvp/variants/cfl_s/include/variant/hda_verb.h R src/mainboard/intel/coffeelake_rvp/variants/cml_u/hda_verb.c C src/mainboard/intel/coffeelake_rvp/variants/whl_u/hda_verb.c D src/mainboard/intel/coffeelake_rvp/variants/whl_u/include/variant/hda_verb.h 8 files changed, 1 insertion(+), 893 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/48360/3
Angel Pons has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/48360 )
Change subject: mb/intel/coffeelake_rvp: Stop using headers for HDA verbs ......................................................................
Removed Code-Review-2 by Angel Pons th3fanbus@gmail.com
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48360 )
Change subject: mb/intel/coffeelake_rvp: Stop using headers for HDA verbs ......................................................................
Patch Set 3: Code-Review+2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48360 )
Change subject: mb/intel/coffeelake_rvp: Stop using headers for HDA verbs ......................................................................
mb/intel/coffeelake_rvp: Stop using headers for HDA verbs
One of the variants lacks an hda_verb.h, and hda_verb.c can't be built. Follow-up changes will make mainboard hda_verb.c files always get built through AZALIA_PLUGIN_SUPPORT, and breaks building this contraption.
Turn the headers into standalone compilation units to prevent this issue. Since they contain definitions, including them from multiple compilation units wasn't a good idea anyway.
Change-Id: I00d968563539a4e1b8d1e12145293439d8358555 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48360 Reviewed-by: Patrick Rudolph siro@das-labor.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/intel/coffeelake_rvp/Makefile.inc D src/mainboard/intel/coffeelake_rvp/hda_verb.c R src/mainboard/intel/coffeelake_rvp/variants/cfl_h/hda_verb.c C src/mainboard/intel/coffeelake_rvp/variants/cfl_s/hda_verb.c D src/mainboard/intel/coffeelake_rvp/variants/cfl_s/include/variant/hda_verb.h R src/mainboard/intel/coffeelake_rvp/variants/cml_u/hda_verb.c C src/mainboard/intel/coffeelake_rvp/variants/whl_u/hda_verb.c D src/mainboard/intel/coffeelake_rvp/variants/whl_u/include/variant/hda_verb.h 8 files changed, 1 insertion(+), 893 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/mainboard/intel/coffeelake_rvp/Makefile.inc b/src/mainboard/intel/coffeelake_rvp/Makefile.inc index a3061e3..77f0691 100644 --- a/src/mainboard/intel/coffeelake_rvp/Makefile.inc +++ b/src/mainboard/intel/coffeelake_rvp/Makefile.inc @@ -10,7 +10,7 @@
ramstage-$(CONFIG_CHROMEOS) += chromeos.c ramstage-y += mainboard.c -ramstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_HDA_VERB) += hda_verb.c +ramstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_HDA_VERB) += variants/$(VARIANT_DIR)/hda_verb.c
subdirs-y += variants/baseboard CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include diff --git a/src/mainboard/intel/coffeelake_rvp/hda_verb.c b/src/mainboard/intel/coffeelake_rvp/hda_verb.c deleted file mode 100644 index c260297..0000000 --- a/src/mainboard/intel/coffeelake_rvp/hda_verb.c +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include "variant/hda_verb.h" diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/hda_verb.h b/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/hda_verb.c similarity index 97% rename from src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/hda_verb.h rename to src/mainboard/intel/coffeelake_rvp/variants/cfl_h/hda_verb.c index e276cf7..cbe8f0b 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/hda_verb.h +++ b/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/hda_verb.c @@ -1,8 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#ifndef HDA_VERB_H -#define HDA_VERB_H - #include <device/azalia_device.h>
const u32 cim_verb_data[] = { @@ -183,4 +180,3 @@ };
AZALIA_ARRAY_SIZES; -#endif diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/hda_verb.h b/src/mainboard/intel/coffeelake_rvp/variants/cfl_s/hda_verb.c similarity index 97% copy from src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/hda_verb.h copy to src/mainboard/intel/coffeelake_rvp/variants/cfl_s/hda_verb.c index e276cf7..cbe8f0b 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/hda_verb.h +++ b/src/mainboard/intel/coffeelake_rvp/variants/cfl_s/hda_verb.c @@ -1,8 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#ifndef HDA_VERB_H -#define HDA_VERB_H - #include <device/azalia_device.h>
const u32 cim_verb_data[] = { @@ -183,4 +180,3 @@ };
AZALIA_ARRAY_SIZES; -#endif diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cfl_s/include/variant/hda_verb.h b/src/mainboard/intel/coffeelake_rvp/variants/cfl_s/include/variant/hda_verb.h deleted file mode 100644 index e276cf7..0000000 --- a/src/mainboard/intel/coffeelake_rvp/variants/cfl_s/include/variant/hda_verb.h +++ /dev/null @@ -1,186 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#ifndef HDA_VERB_H -#define HDA_VERB_H - -#include <device/azalia_device.h> - -const u32 cim_verb_data[] = { - - /* - * VerbTable: CFL Display Audio Codec - * Revision ID = 0xFF - * Codec Vendor: 0x8086280B - */ - - 0x8086280B, - 0xFFFFFFFF, - 0x00000005, - - /* - * Display Audio Verb Table - * For GEN9, the Vendor Node ID is 08h - * Port to be exposed to the inbox driver in the vanilla mode - * PORT C - BIT[7:6] = 01b - */ - 0x00878140, - 0x00878140, - 0x00878140, - 0x00878140, - /* Pin Widget 5 - PORT B - Configuration Default: 0x18560010 */ - 0x00571C10, - 0x00571D00, - 0x00571E56, - 0x00571F18, - /* Pin Widget 6 - PORT C - Configuration Default: 0x18560020 */ - 0x00671C20, - 0x00671D00, - 0x00671E56, - 0x00671F18, - /* Pin Widget 7 - PORT D - Configuration Default: 0x18560030 */ - 0x00771C30, - 0x00771D00, - 0x00771E56, - 0x00771F18, - /* Disable the third converter and third Pin (NID 08h) */ - 0x00878140, - 0x00878140, - 0x00878140, - 0x00878140, - - /* ALC700 */ - 0x10EC0700, - 0xFFFFFFFF, - 0x00000015, - - /* - * HDA Codec Subsystem ID Verb-table - * HDA Codec Subsystem ID : 0x10EC112C - */ - 0x0017202C, - 0x00172111, - 0x001722EC, - 0x00172310, - - /* - * Pin Widget Verb-table - * Widget node 0x01 - */ - 0x0017FF00, - 0x0017FF00, - 0x0017FF00, - 0x0017FF00, - /* Pin widget 0x12 - DMIC */ - 0x01271C00, - 0x01271D00, - 0x01271E00, - 0x01271F40, - /* Pin widget 0x13 - DMIC */ - 0x01371CF0, - 0x01371D11, - 0x01371E11, - 0x01371F41, - /* Pin widget 0x14 - FRONT (Port-D) */ - 0x01471CF0, - 0x01471D11, - 0x01471E11, - 0x01471F41, - /* Pin widget 0x15 - I2S-OUT */ - 0x01571C10, - 0x01571D01, - 0x01571E17, - 0x01571F90, - /* Pin widget 0x16 - LINE3 (Port-B) */ - 0x01671C20, - 0x01671D10, - 0x01671E01, - 0x01671F01, - /* Pin widget 0x17 - I2S-OUT */ - 0x01771CF0, - 0x01771D11, - 0x01771E11, - 0x01771F41, - /* Pin widget 0x18 - I2S-IN */ - 0x01871CF0, - 0x01871D11, - 0x01871E11, - 0x01871F41, - /* Pin widget 0x19 - MIC2 (Port-F) */ - 0x01971C30, - 0x01971D90, - 0x01971EA1, - 0x01971F02, - /* Pin widget 0x1A - LINE1 (Port-C) */ - 0x01A71CF0, - 0x01A71D11, - 0x01A71E11, - 0x01A71F41, - /* Pin widget 0x1B - LINE2 (Port-E) */ - 0x01B71C40, - 0x01B71D90, - 0x01B71EA1, - 0x01B71F01, - /* Pin widget 0x1D - PC-BEEP */ - 0x01D71C69, - 0x01D71D84, - 0x01D71E45, - 0x01D71F40, - /* Pin widget 0x1E - S/PDIF-OUT */ - 0x01E71CF0, - 0x01E71D11, - 0x01E71E11, - 0x01E71F41, - /* Pin widget 0x1F - S/PDIF-IN */ - 0x01F71CF0, - 0x01F71D11, - 0x01F71E11, - 0x01F71F41, - /* Pin widget 0x21 - P-OUT (Port-I) */ - 0x02171C2F, - 0x02171D10, - 0x02171E21, - 0x02171F02, - /* Pin widget 0x29 - I2S-IN */ - 0x02971CF0, - 0x02971D11, - 0x02971E11, - 0x02971F41, - /* - * Widget node 0x20 : MIC2-Vrefo-R and MIC2-vrefo-L - * to independent control - */ - 0x02050045, - 0x02045089, - 0x0205004A, - 0x0204201B, - /* Widget node 0x20 - 1 */ - 0x05850000, - 0x05843888, - 0x0205006F, - 0x02042C0B, - /* - * Widget node 0x20 - 2 : Line2-JD gating MIC2-Vrefo-R, - * P-JD gating MIC2-vrefo-L - */ - 0x0205006B, - 0x02044260, - 0x05B50010, - 0x05B45C1D, - - /* Widget node 0X20 for ALC1305 */ - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040000, - 0x02050028, - 0x02040000, - 0x02050029, - 0x0204B024, - -}; - -const u32 pc_beep_verbs[] = { -}; - -AZALIA_ARRAY_SIZES; -#endif diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/include/variant/hda_verb.h b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/hda_verb.c similarity index 98% rename from src/mainboard/intel/coffeelake_rvp/variants/cml_u/include/variant/hda_verb.h rename to src/mainboard/intel/coffeelake_rvp/variants/cml_u/hda_verb.c index 7233250..01012dd 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/include/variant/hda_verb.h +++ b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/hda_verb.c @@ -1,8 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#ifndef HDA_VERB_H -#define HDA_VERB_H - #include <device/azalia_device.h>
const u32 cim_verb_data[] = { @@ -684,4 +681,3 @@ const u32 pc_beep_verbs[] = { }; AZALIA_ARRAY_SIZES; -#endif diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/include/variant/hda_verb.h b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/hda_verb.c similarity index 98% copy from src/mainboard/intel/coffeelake_rvp/variants/cml_u/include/variant/hda_verb.h copy to src/mainboard/intel/coffeelake_rvp/variants/whl_u/hda_verb.c index 7233250..01012dd 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/include/variant/hda_verb.h +++ b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/hda_verb.c @@ -1,8 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#ifndef HDA_VERB_H -#define HDA_VERB_H - #include <device/azalia_device.h>
const u32 cim_verb_data[] = { @@ -684,4 +681,3 @@ const u32 pc_beep_verbs[] = { }; AZALIA_ARRAY_SIZES; -#endif diff --git a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/include/variant/hda_verb.h b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/include/variant/hda_verb.h deleted file mode 100644 index 7233250..0000000 --- a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/include/variant/hda_verb.h +++ /dev/null @@ -1,687 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#ifndef HDA_VERB_H -#define HDA_VERB_H - -#include <device/azalia_device.h> - -const u32 cim_verb_data[] = { - /* ALC 700 */ - 0x10EC0700, - 0xFFFFFFFF, - 0x00000023, - - AZALIA_SUBVENDOR(0, 0x10EC10F2), - AZALIA_PIN_CFG(0, 0x01, 0x00000000), - AZALIA_PIN_CFG(0, 0x12, 0x40000000), - AZALIA_PIN_CFG(0, 0x13, 0x40000000), - AZALIA_PIN_CFG(0, 0x14, 0x411111F0), - AZALIA_PIN_CFG(0, 0x15, 0x411111F0), - AZALIA_PIN_CFG(0, 0x16, 0x411111F0), - AZALIA_PIN_CFG(0, 0x17, 0x90170110), - AZALIA_PIN_CFG(0, 0x18, 0x411111F0), - AZALIA_PIN_CFG(0, 0x19, 0x04A11030), - AZALIA_PIN_CFG(0, 0x1A, 0x411111F0), - AZALIA_PIN_CFG(0, 0x1B, 0x411111F0), - AZALIA_PIN_CFG(0, 0x1D, 0x40622005), - AZALIA_PIN_CFG(0, 0x1E, 0x411111F0), - AZALIA_PIN_CFG(0, 0x1F, 0x411111F0), - AZALIA_PIN_CFG(0, 0x21, 0x04211020), - AZALIA_PIN_CFG(0, 0x29, 0x411111F0), - - /* Widget node 0x20 */ - 0x02050045, - 0x02045289, - 0x0205004A, - 0x0204201B, - /* Widget node 0x20 - 1 */ - 0x05850000, - 0x05843888, - 0x0205006F, - 0x02042C0B, - - //Widget node 0X20 for ALC1305 20160603 update - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040000, - 0x02050028, - 0x02040000, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040004, - 0x02050028, - 0x02040600, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x0204003C, - 0x02050028, - 0x0204FFD0, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040080, - 0x02050028, - 0x02040080, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040080, - 0x02050028, - 0x02040880, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x0204003A, - 0x02050028, - 0x02040DFE, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x0204006A, - 0x02050028, - 0x0204005D, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x0204006C, - 0x02050028, - 0x02040442, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040005, - 0x02050028, - 0x02040880, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040006, - 0x02050028, - 0x02040000, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040008, - 0x02050028, - 0x0204B000, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x0204002E, - 0x02050028, - 0x02040800, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x0204006A, - 0x02050028, - 0x020400C3, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x0204006C, - 0x02050028, - 0x0204D4A0, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x0204006A, - 0x02050028, - 0x020400CC, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x0204006C, - 0x02050028, - 0x0204400A, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x0204006A, - 0x02050028, - 0x020400C1, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x0204006C, - 0x02050028, - 0x02040320, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040039, - 0x02050028, - 0x02040000, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x0204003B, - 0x02050028, - 0x0204FFFF, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x0204003C, - 0x02050028, - 0x0204FC20, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x0204003A, - 0x02050028, - 0x02041DFE, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x020400C0, - 0x02050028, - 0x020401FA, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x020400C1, - 0x02050028, - 0x0204DE23, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x020400C2, - 0x02050028, - 0x02041C00, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x020400C3, - 0x02050028, - 0x02040000, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x020400C4, - 0x02050028, - 0x02040200, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x020400C5, - 0x02050028, - 0x02040000, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x020400C6, - 0x02050028, - 0x020403F5, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x020400C7, - 0x02050028, - 0x0204AF1B, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x020400C8, - 0x02050028, - 0x02041E0A, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x020400C9, - 0x02050028, - 0x0204368E, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x020400CA, - 0x02050028, - 0x020401FA, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x020400CB, - 0x02050028, - 0x0204DE23, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x020400CC, - 0x02050028, - 0x02041C00, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x020400CD, - 0x02050028, - 0x02040000, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x020400CE, - 0x02050028, - 0x02040200, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x020400CF, - 0x02050028, - 0x02040000, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x020400D0, - 0x02050028, - 0x020403F5, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x020400D1, - 0x02050028, - 0x0204AF1B, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x020400D2, - 0x02050028, - 0x02041E0A, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x020400D3, - 0x02050028, - 0x0204368E, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040040, - 0x02050028, - 0x0204800F, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040062, - 0x02050028, - 0x02048000, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040063, - 0x02050028, - 0x02044848, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040064, - 0x02050028, - 0x02040800, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040065, - 0x02050028, - 0x02040000, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040066, - 0x02050028, - 0x02044004, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040067, - 0x02050028, - 0x02040802, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040068, - 0x02050028, - 0x0204890F, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040069, - 0x02050028, - 0x0204E021, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040070, - 0x02050028, - 0x02040000, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040071, - 0x02050000, - 0x02043330, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040072, - 0x02050000, - 0x02043333, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040073, - 0x02050028, - 0x02040000, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040074, - 0x02050028, - 0x02040000, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040075, - 0x02050028, - 0x02040000, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040076, - 0x02050028, - 0x02040000, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040050, - 0x02050028, - 0x020402EC, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040051, - 0x02050028, - 0x02044909, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040052, - 0x02050028, - 0x020440B0, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040046, - 0x02050028, - 0x0204C22E, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040047, - 0x02050028, - 0x02040C00, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040048, - 0x02050028, - 0x02040000, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040049, - 0x02050028, - 0x02040000, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x0204004A, - 0x02050028, - 0x02040000, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x0204004B, - 0x02050028, - 0x02041C00, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x0204006A, - 0x02050028, - 0x02040090, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x0204006C, - 0x02050028, - 0x0204721F, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x0204009E, - 0x02050028, - 0x02040001, - 0x02050029, - 0x0204B024, - - 0x02050024, - 0x02040010, - 0x02050026, - 0x02040004, - 0x02050028, - 0x02040500, - 0x02050029, - 0x0204B024 -}; - -const u32 pc_beep_verbs[] = { -}; -AZALIA_ARRAY_SIZES; -#endif
-
Angel Pons (Code Review) -
Felix Singer (Code Review)
-
Hung-Te Lin (Code Review)
-
Michael Niewöhner (Code Review)
-
Patrick Rudolph (Code Review)