Patch Set 2:

Patch Set 2:

Patch Set 2:

Empty c files instead of empty headers? How does that make a difference? The right way is to have no files when none are required -> fix the build system

I don't think he meant replacing the header file by an empty C file.

  #include "variant/hda_verb.h"

This is from mb/intel/coffeelake_rvp/hda_verb.c, which requires every variant to have such a header file. I think what he suggested was to move the hda_verb.c to the variant directories and add them to their Makefile.inc, if needed.

That's not what I understood from the commit message tbh

Angel, could you explain what exactly the change is trying to achieve - I must be missing something here

I fear you've mixed what this change does with the idea I had later on, and naturally ended up very confused. I'm going to scrap this change, and instead do what I just wrote in the reply to Felix (which does not involve adding any empty files; in fact, one file will be removed).

Hope this helps 😊

View Change

To view, visit change 48360. To unsubscribe, or for help writing mail filters, visit settings.