Change in coreboot[master]: mb/getac/p470: Insist on combined mode

List overview All Threads
Download

newer

older

Change in ...libgfxinit[master]:...

Patrick Georgi (Code Review)

20 Jul 2019 20 Jul '19

4:18 p.m.

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34461 )

Change subject: mb/getac/p470: Insist on combined mode ......................................................................

mb/getac/p470: Insist on combined mode

Without that flag my p470 finds neither HDD (on SATA) nor DVD drive (on PATA).

Change-Id: Ic3fdaeb866e235224e4ec9893ca5790f59c3943e Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/getac/p470/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/34461/1

diff --git a/src/mainboard/getac/p470/devicetree.cb b/src/mainboard/getac/p470/devicetree.cb index c994553..c0b3471 100644 --- a/src/mainboard/getac/p470/devicetree.cb +++ b/src/mainboard/getac/p470/devicetree.cb @@ -42,6 +42,7 @@ register "pirqf_routing" = "0x80" register "pirqg_routing" = "0x0a" register "pirqh_routing" = "0x0a" + register "sata_mode" = "SATA_MODE_IDE_LEGACY_COMBINED"

# GPI routing # 0 No effect (default)

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Angel Pons (Code Review)

20 Jul 20 Jul

4:37 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34461 )

Change subject: mb/getac/p470: Insist on combined mode ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/34461 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3fdaeb866e235224e4ec9893ca5790f59c3943e Gerrit-Change-Number: 34461 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 20 Jul 2019 14:37:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Stefan Reinauer (Code Review)

4:45 p.m.

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34461 )

Change subject: mb/getac/p470: Insist on combined mode ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34461 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3fdaeb866e235224e4ec9893ca5790f59c3943e Gerrit-Change-Number: 34461 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 20 Jul 2019 14:45:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

4:51 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34461 )

Change subject: mb/getac/p470: Insist on combined mode ......................................................................

Patch Set 1:

So this was introduced by CB:30822, and we now have a non-functional ide_legacy_combined chip configuration field (defined in chip.h, but never read) that is still used on various i82801gx-based boards.

Arthur, what should we do about that?

-- To view, visit https://review.coreboot.org/c/coreboot/+/34461 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3fdaeb866e235224e4ec9893ca5790f59c3943e Gerrit-Change-Number: 34461 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 20 Jul 2019 14:51:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

4:55 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34461 )

Change subject: mb/getac/p470: Insist on combined mode ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/34461 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3fdaeb866e235224e4ec9893ca5790f59c3943e Gerrit-Change-Number: 34461 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 20 Jul 2019 14:55:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

5:09 p.m.

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34461 )

Change subject: mb/getac/p470: Insist on combined mode ......................................................................

Abandoned

See CB:34462

-- To view, visit https://review.coreboot.org/c/coreboot/+/34461 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3fdaeb866e235224e4ec9893ca5790f59c3943e Gerrit-Change-Number: 34461 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: abandon

Angel Pons (Code Review)

6:59 p.m.

Angel Pons has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/34461 )

Change subject: mb/getac/p470: Insist on combined mode ......................................................................

Removed Code-Review+1 by Angel Pons th3fanbus@gmail.com

-- To view, visit https://review.coreboot.org/c/coreboot/+/34461 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3fdaeb866e235224e4ec9893ca5790f59c3943e Gerrit-Change-Number: 34461 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: deleteVote

2109

days inactive

2109

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)
Patrick Georgi (Code Review)
Stefan Reinauer (Code Review)