Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34461 )
Change subject: mb/getac/p470: Insist on combined mode ......................................................................
mb/getac/p470: Insist on combined mode
Without that flag my p470 finds neither HDD (on SATA) nor DVD drive (on PATA).
Change-Id: Ic3fdaeb866e235224e4ec9893ca5790f59c3943e Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/getac/p470/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/34461/1
diff --git a/src/mainboard/getac/p470/devicetree.cb b/src/mainboard/getac/p470/devicetree.cb index c994553..c0b3471 100644 --- a/src/mainboard/getac/p470/devicetree.cb +++ b/src/mainboard/getac/p470/devicetree.cb @@ -42,6 +42,7 @@ register "pirqf_routing" = "0x80" register "pirqg_routing" = "0x0a" register "pirqh_routing" = "0x0a" + register "sata_mode" = "SATA_MODE_IDE_LEGACY_COMBINED"
# GPI routing # 0 No effect (default)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34461 )
Change subject: mb/getac/p470: Insist on combined mode ......................................................................
Patch Set 1: Code-Review+1
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34461 )
Change subject: mb/getac/p470: Insist on combined mode ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34461 )
Change subject: mb/getac/p470: Insist on combined mode ......................................................................
Patch Set 1:
So this was introduced by CB:30822, and we now have a non-functional ide_legacy_combined chip configuration field (defined in chip.h, but never read) that is still used on various i82801gx-based boards.
Arthur, what should we do about that?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34461 )
Change subject: mb/getac/p470: Insist on combined mode ......................................................................
Patch Set 1: Code-Review+1
Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34461 )
Change subject: mb/getac/p470: Insist on combined mode ......................................................................
Abandoned
See CB:34462
Angel Pons has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/34461 )
Change subject: mb/getac/p470: Insist on combined mode ......................................................................
Removed Code-Review+1 by Angel Pons th3fanbus@gmail.com