Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34461 )
Change subject: mb/getac/p470: Insist on combined mode
......................................................................
Patch Set 1:
So this was introduced by CB:30822, and we now have a non-functional ide_legacy_combined chip configuration field (defined in chip.h, but never read) that is still used on various i82801gx-based boards.
Arthur, what should we do about that?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34461
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3fdaeb866e235224e4ec9893ca5790f59c3943e
Gerrit-Change-Number: 34461
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 20 Jul 2019 14:51:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment