Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33136 )
Change subject: mb/up/squared: Remove unnecessary code
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/33136/4/src/mainboard/up/squared/ramstage.c
File src/mainboard/up/squared/ramstage.c:
https://review.coreboot.org/#/c/33136/4/src/mainboard/up/squared/ramstage.c@...
PS4, Line 57: silconfig->WriteProtectionEnable[0] = 0x1; // 0x0
I think we don't need WriteProtectionEnable/ReadProtectionEnable here and can do it in coreboot
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33136
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7dae4f24a9fcb01d2d47063dd3a0f4ce6c120d2
Gerrit-Change-Number: 33136
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 01 Jun 2019 07:46:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment