Change in ...coreboot[master]: doc/mb/upsquared: Add documentation
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32935 ) Change subject: doc/mb/upsquared: Add documentation ...................................................................... Patch Set 7: Code-Review+1 (2 comments) https://review.coreboot.org/#/c/32935/7/Documentation/soc/intel/apollolake/i... File Documentation/soc/intel/apollolake/index.md: https://review.coreboot.org/#/c/32935/7/Documentation/soc/intel/apollolake/i... PS7, Line 3: ![][apl_flash_layout] missing topic: ## SPI flash layout https://review.coreboot.org/#/c/32935/7/Documentation/soc/intel/apollolake/i... PS7, Line 7: Usually on x86 platforms the bootblock is stored at the end of the bios region and the Intel ME / TXE has its own IFD region. On Apollolake both have been moved into the IFWI region, which is a subregion of "BIOS", since it allows to store multiple firmware components. 80 char limit per line -- To view, visit https://review.coreboot.org/c/coreboot/+/32935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic708ddbd2616eee4e5ec2740b3eac18b408bde38 Gerrit-Change-Number: 32935 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Sat, 01 Jun 2019 07:38:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
participants (1)
-
Patrick Rudolph (Code Review)