Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32935 )
Change subject: doc/mb/upsquared: Add documentation ......................................................................
Patch Set 7: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/32935/7/Documentation/soc/intel/apollolake/i... File Documentation/soc/intel/apollolake/index.md:
https://review.coreboot.org/#/c/32935/7/Documentation/soc/intel/apollolake/i... PS7, Line 3: ![][apl_flash_layout] missing topic: ## SPI flash layout
https://review.coreboot.org/#/c/32935/7/Documentation/soc/intel/apollolake/i... PS7, Line 7: Usually on x86 platforms the bootblock is stored at the end of the bios region and the Intel ME / TXE has its own IFD region. On Apollolake both have been moved into the IFWI region, which is a subregion of "BIOS", since it allows to store multiple firmware components. 80 char limit per line