HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37890 )
Change subject: lib/ubsan: Drop GNUC < 6 guard ......................................................................
lib/ubsan: Drop GNUC < 6 guard
We currently use GCC-8.3.0
Change-Id: I57bae238cc65af34ff0bbf653de156bf0d0181d0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/lib/ubsan.c 1 file changed, 0 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/37890/1
diff --git a/src/lib/ubsan.c b/src/lib/ubsan.c index 1283400..8ab67f0 100644 --- a/src/lib/ubsan.c +++ b/src/lib/ubsan.c @@ -242,15 +242,6 @@ ABORT_VARIANT_VP_VP(vla_bound_not_positive);
struct ubsan_float_cast_overflow_data { -/* -* TODO: Remove this GCC 5.x compatibility after switching to GCC 6.x. The -* GCC developers accidentally forgot the source location. Their -* libubsan probes to see if it looks like a path, but we don't need -* to maintain compatibility with multiple gcc releases. See below. -*/ -#if !(defined(__GNUC__) && __GNUC__ < 6) - struct ubsan_source_location location; -#endif struct ubsan_type_descriptor *from_type; struct ubsan_type_descriptor *to_type; }; @@ -261,11 +252,7 @@ (struct ubsan_float_cast_overflow_data *)data_raw; ubsan_value_handle_t from = (ubsan_value_handle_t)from_raw; (void) from; -#if !(defined(__GNUC__) && __GNUC__ < 6) - ubsan_abort(&data->location, "float cast overflow"); -#else ubsan_abort(((void) data, &unknown_location), "float cast overflow"); -#endif }
ABORT_VARIANT_VP_VP(float_cast_overflow);
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37890 )
Change subject: lib/ubsan: Drop GNUC < 6 guard ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37890/1/src/lib/ubsan.c File src/lib/ubsan.c:
https://review.coreboot.org/c/coreboot/+/37890/1/src/lib/ubsan.c@a251 PS1, Line 251: #if !(defined(__GNUC__) && __GNUC__ < 6) if not GCC < 6: add this line is equivelant to if GCC >= 6: add this line, so I guess we should always keep the struct member?
https://review.coreboot.org/c/coreboot/+/37890/1/src/lib/ubsan.c@a264 PS1, Line 264: #if !(defined(__GNUC__) && __GNUC__ < 6) ditto
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37890 )
Change subject: lib/ubsan: Drop GNUC < 6 guard ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37890/1/src/lib/ubsan.c File src/lib/ubsan.c:
https://review.coreboot.org/c/coreboot/+/37890/1/src/lib/ubsan.c@a251 PS1, Line 251: #if !(defined(__GNUC__) && __GNUC__ < 6)
if not GCC < 6: add this line is equivelant to if GCC >= 6: add this line, so I guess we should alwa […]
Oops :)
Thx
https://review.coreboot.org/c/coreboot/+/37890/1/src/lib/ubsan.c@a264 PS1, Line 264: #if !(defined(__GNUC__) && __GNUC__ < 6)
ditto
Done
Hello build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37890
to look at the new patch set (#2).
Change subject: lib/ubsan: Drop GNUC < 6 guard ......................................................................
lib/ubsan: Drop GNUC < 6 guard
We currently use GCC-8.3.0
Change-Id: I57bae238cc65af34ff0bbf653de156bf0d0181d0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/lib/ubsan.c 1 file changed, 0 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/37890/2
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37890 )
Change subject: lib/ubsan: Drop GNUC < 6 guard ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)