HAOUAS Elyes has uploaded this change for review.

View Change

lib/ubsan: Drop GNUC < 6 guard

We currently use GCC-8.3.0

Change-Id: I57bae238cc65af34ff0bbf653de156bf0d0181d0
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
---
M src/lib/ubsan.c
1 file changed, 0 insertions(+), 13 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/37890/1

diff --git a/src/lib/ubsan.c b/src/lib/ubsan.c
index 1283400..8ab67f0 100644
--- a/src/lib/ubsan.c
+++ b/src/lib/ubsan.c
@@ -242,15 +242,6 @@
 ABORT_VARIANT_VP_VP(vla_bound_not_positive);
 
 struct ubsan_float_cast_overflow_data {
-/*
-* TODO: Remove this GCC 5.x compatibility after switching to GCC 6.x. The
-* GCC developers accidentally forgot the source location. Their
-* libubsan probes to see if it looks like a path, but we don't need
-* to maintain compatibility with multiple gcc releases. See below.
-*/
-#if !(defined(__GNUC__) && __GNUC__ < 6)
-	struct ubsan_source_location location;
-#endif
 	struct ubsan_type_descriptor *from_type;
 	struct ubsan_type_descriptor *to_type;
 };
@@ -261,11 +252,7 @@
 		(struct ubsan_float_cast_overflow_data *)data_raw;
 	ubsan_value_handle_t from = (ubsan_value_handle_t)from_raw;
 	(void) from;
-#if !(defined(__GNUC__) && __GNUC__ < 6)
-	ubsan_abort(&data->location, "float cast overflow");
-#else
 	ubsan_abort(((void) data, &unknown_location), "float cast overflow");
-#endif
 }
 
 ABORT_VARIANT_VP_VP(float_cast_overflow);

To view, visit change 37890. To unsubscribe, or for help writing mail filters, visit settings.