Change in ...coreboot[master]: mb/google/hatch: Update GPIO settings

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Krishna P Bhat D (Code Review)

3 Apr 2019 3 Apr '19

3:50 p.m.

Krishna P Bhat D has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32176

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

mb/google/hatch: Update GPIO settings

This patch updates the following GPIO settings. 1. Set Native termination for GPP_G0 - G4 SD card pins. 2. Disable I2C #2 in devicetree. 3. Set GPP_B19, GPP_G7 to NF1.

BUG=b:123907904

Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Signed-off-by: Krishna Prasad Bhat krishna.p.bhat.d@intel.com --- M src/mainboard/google/hatch/variants/baseboard/gpio.c M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb 3 files changed, 11 insertions(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/32176/1

diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 4d1c87e..10f851b 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -106,8 +106,8 @@ PAD_CFG_NF(GPP_B17, NONE, DEEP, NF1), /* B18 : H1_SLAVE_SPI_MOSI_R */ PAD_CFG_NF(GPP_B18, NONE, DEEP, NF1), - /* B19 : GPP_B19 ==> NC */ - PAD_NC(GPP_B19, NONE), + /* B19 : Set to NF1 */ + PAD_CFG_NF(GPP_B19, NONE, DEEP, NF1), /* B20 : PCH_SPI_FPMCU_CLK_R */ PAD_CFG_NF(GPP_B20, NONE, DEEP, NF1), /* B21 : PCH_SPI_FPMCU_MISO */ @@ -329,21 +329,21 @@ PAD_NC(GPP_F23, NONE),

/* G0 : SD_CMD */ - PAD_CFG_NF(GPP_G0, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_G0, NATIVE, DEEP, NF1), /* G1 : SD_DATA0 */ - PAD_CFG_NF(GPP_G1, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_G1, NATIVE, DEEP, NF1), /* G2 : SD_DATA1 */ - PAD_CFG_NF(GPP_G2, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_G2, NATIVE, DEEP, NF1), /* G3 : SD_DATA2 */ - PAD_CFG_NF(GPP_G3, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_G3, NATIVE, DEEP, NF1), /* G4 : SD_DATA3 */ - PAD_CFG_NF(GPP_G4, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_G4, NATIVE, DEEP, NF1), /* G5 : SD_CD# */ PAD_CFG_NF(GPP_G5, NONE, DEEP, NF1), /* G6 : SD_CLK */ PAD_CFG_NF(GPP_G6, NONE, DEEP, NF1), - /* G7 : SD_WP => NC */ - PAD_NC(GPP_G7, DN_20K), + /* G7 : Set to NF1 */ + PAD_CFG_NF(GPP_G7, NONE, DEEP, NF1),

/* * H0 : HP_INT_L diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb index 28644d1..57daba2 100644 --- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -69,7 +69,7 @@ device i2c 49 on end end end # I2C #1 - device pci 15.2 on + device pci 15.2 off chip drivers/generic/gpio_keys register "name" = ""PENH"" register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_HIGH(GPP_A8)" diff --git a/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb b/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb index 9b772c2..098bca6 100644 --- a/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb @@ -54,7 +54,7 @@ device i2c 49 on end end end # I2C #1 - device pci 15.2 on + device pci 15.2 off chip drivers/generic/gpio_keys register "name" = ""PENH"" register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_HIGH(GPP_A8)"

Attachments:

attachment.htm (text/html — 6.4 KB)

Show replies by date

Krishna P Bhat D (Code Review)

4 Apr 4 Apr

10:29 a.m.

Hello Rizwan Qureshi, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32176

to look at the new patch set (#2).

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

mb/google/hatch: Update GPIO settings

This patch updates the following GPIO settings. 1. Set Native termination for GPP_G0 - G4 SD card pins. 2. Disable I2C #2 in devicetree. 3. Set GPP_B19, GPP_G7 to NF1.

BUG=b:123907904

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/32176/2

Krishna P Bhat D (Code Review)

10:48 a.m.

Hello Rizwan Qureshi, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32176

to look at the new patch set (#3).

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

mb/google/hatch: Update GPIO settings

This patch updates the following GPIO settings. 1. Set Native termination for GPP_G0 - G4 SD card pins, pull-down termination for GPP_G7 SD card Write Protect pin. 2. Disable I2C #2 in variant devicetree. 3. Set GPP_B19 to NF1.

BUG=b:123907904

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/32176/3

Tim Wawrzynczak (Code Review)

5 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 3 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 04 Apr 2019 17:00:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Rizwan Qureshi (Code Review)

15 Apr 15 Apr

11:43 a.m.

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 3:

please rebase the patch and also add what tests you have performed after changing the GPIO configuration.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 3 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 15 Apr 2019 11:43:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Krishna P Bhat D (Code Review)

16 Apr 16 Apr

4:56 a.m.

Hello Rizwan Qureshi, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32176

to look at the new patch set (#4).

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

mb/google/hatch: Update GPIO settings

This patch updates the following GPIO settings. 1. Set Native termination for GPP_G0 - G4 SD card pins, pull-down termination for GPP_G7 SD card Write Protect pin. 2. Set GPP_B19 to NF1.

BUG=b:123907904 TEST=Verified SD card functionality on hatch. Checked for SD detection, transferred files to and from SD card.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/32176/4

Furquan Shaikh (Code Review)

5:10 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/... PS4, Line 32: PAD_NC(GPP_A7, NONE), What about this? Don't you need NF here?

https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/... PS4, Line 332: NATIVE Is this the recommendation for SD controller or for all controllers?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 4 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 16 Apr 2019 05:10:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Rizwan Qureshi (Code Review)

6:24 a.m.

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/... PS4, Line 32: PAD_NC(GPP_A7, NONE),

...

What about this? Don't you need NF here?

CS1 is not being configured in FSP.

https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/... PS4, Line 332: NATIVE

...

Is this the recommendation for SD controller or for all controllers?

This is only for SD Controller.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 4 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 16 Apr 2019 06:24:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

11:57 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 4:

(3 comments)

https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/... PS4, Line 32: PAD_NC(GPP_A7, NONE),

...

CS1 is not being configured in FSP.

This is really weird. It seems completely broken to me. How does FSP decide which CS has to be configured?

https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/... PS4, Line 345: Set to NF1 Keep as SD_WP to match the other comments.

https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/... PS4, Line 346: DN_20K Does FSP configure this too?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 4 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 16 Apr 2019 23:57:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rizwan Qureshi rizwan.qureshi@intel.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

17 Apr 17 Apr

2:37 a.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/... PS4, Line 109: /* B19 : Set to NF1 */ : PAD_CFG_NF(GPP_B19, NONE, DEEP, NF1), This is still a NC in the Hatch 2.1 reference schematic.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 4 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 17 Apr 2019 02:37:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

2:43 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/... PS4, Line 109: /* B19 : Set to NF1 */ : PAD_CFG_NF(GPP_B19, NONE, DEEP, NF1),

...

This is still a NC in the Hatch 2.1 reference schematic.

Yeah, it is being set here just to match what FSP is doing.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 4 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 17 Apr 2019 02:43:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Rizwan Qureshi (Code Review)

22 Apr 22 Apr

9:17 a.m.

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/... PS4, Line 32: PAD_NC(GPP_A7, NONE),

...

This is really weird. It seems completely broken to me. […]

Actually it seems like a miss in FSP, i am following it up internally to get it fixed.

https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/... PS4, Line 346: DN_20K

...

Does FSP configure this too?

No, FSP is just setting it a native mode along with other SD controller pins. Checking to make this configuration optional.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 4 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 22 Apr 2019 09:17:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rizwan Qureshi rizwan.qureshi@intel.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Krishna P Bhat D (Code Review)

15 May 15 May

4:01 a.m.

Hello Rizwan Qureshi, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32176

to look at the new patch set (#5).

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

mb/google/hatch: Update GPIO settings

This patch updates the following GPIO settings. 1. Set Native termination for GPP_G0 - G4 SD card pins, pull-down termination for GPP_G7 SD card Write Protect pin. 2. Set GPP_B19 to NF1.

BUG=b:123907904 TEST=Verified SD card functionality on hatch. Checked for SD detection, transferred files to and from SD card.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/32176/5

Furquan Shaikh (Code Review)

4:07 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/32176/5/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32176/5/src/mainboard/google/hatch/variants/... PS5, Line 109: Set to NF1 Can you add a comment indicating why this is set to NF1 even though it is unused.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 5 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 15 May 2019 04:07:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Krishna P Bhat D (Code Review)

4:16 a.m.

Hello Rizwan Qureshi, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32176

to look at the new patch set (#6).

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

mb/google/hatch: Update GPIO settings

This patch updates the following GPIO settings. 1. Set Native termination for GPP_G0 - G4 SD card pins, pull-down termination for GPP_G7 SD card Write Protect pin. 2. Set GPP_B19 to NF1.

BUG=b:123907904 TEST=Verified SD card functionality on hatch. Checked for SD detection, transferred files to and from SD card.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/32176/6

Krishna P Bhat D (Code Review)

4:16 a.m.

Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/32176/5/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32176/5/src/mainboard/google/hatch/variants/... PS5, Line 109: Set to NF1

...

Can you add a comment indicating why this is set to NF1 even though it is unused.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 6 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 15 May 2019 04:16:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

5:46 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/32176/6/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32176/6/src/mainboard/google/hatch/variants/... PS6, Line 109: /* B19 : Set to NF1 to match FSP setting it to NF1, i.e., GSPI1_CS0# */ : PAD_CFG_NF(GPP_B19, NONE, DEEP, NF1), I am wondering if this can be fixed by setting SerialIoSpi1CsEnable: https://review.coreboot.org/cgit/coreboot.git/tree/src/vendorcode/intel/fsp/...

Did you try playing with it?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 6 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 15 May 2019 05:46:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

17 May 17 May

11:20 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/32176/6/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

...

I am wondering if this can be fixed by setting SerialIoSpi1CsEnable: https://review.coreboot. […]

Were you able to try this out?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 6 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 17 May 2019 23:20:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Krishna P Bhat D (Code Review)

22 May 22 May

10:42 a.m.

Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/32176/6/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

...

Were you able to try this out?

Sorry Furquan for late response. SerialIoSpi1CsEnable is not checked while setting GPIO native function in FSP. Setting it to 0 or 1 does not affect SPI1 CS0 being set to NF1. However, this UPD is checked to set the SPI CS polarity. I would recommend setting this GPIO pin in coreboot to align with the FSP settings.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 6 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 22 May 2019 10:42:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Rizwan Qureshi (Code Review)

24 May 24 May

7:20 a.m.

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/32176/6/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32176/6/src/mainboard/google/hatch/variants/... PS6, Line 341: /* G5 : SD_CD# */ : PAD_CFG_NF(GPP_G5, NONE, DEEP, NF1), This patch will need a rebase, this is set PLTRST in https://review.coreboot.org/c/coreboot/+/32782

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 6 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 24 May 2019 07:20:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Krishna P Bhat D (Code Review)

1:24 p.m.

Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/32176/6/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32176/6/src/mainboard/google/hatch/variants/... PS6, Line 341: /* G5 : SD_CD# */ : PAD_CFG_NF(GPP_G5, NONE, DEEP, NF1),

...

This patch will need a rebase, this is set PLTRST in https://review.coreboot. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 7 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 24 May 2019 13:24:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

2:52 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/32176/7/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32176/7/src/mainboard/google/hatch/variants/... PS7, Line 342: PLTRST Is there a reason SD_CD# is PLTRST and the other signals are DEEP?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 7 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 24 May 2019 14:52:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

4:34 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/32176/7/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32176/7/src/mainboard/google/hatch/variants/... PS7, Line 342: PLTRST

...

Is there a reason SD_CD# is PLTRST and the other signals are DEEP?

Probably because it was triggering interrupt storm when booting from S5?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 7 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 24 May 2019 16:34:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

4:47 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 7: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 7 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 24 May 2019 16:47:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Krishna P Bhat D (Code Review)

30 May 30 May

6:13 a.m.

Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/32176/7/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32176/7/src/mainboard/google/hatch/variants/... PS7, Line 342: PLTRST

...

Probably because it was triggering interrupt storm when booting from S5?

I haven't checked the interrupt storm. I have verified with pad reset config set to DEEP for SD_CD# on hatch proto, we observe that the system waits for few seconds at "Starting kernel" and then resets, when we press the power button before the system enters G3. However, this issue is not observed on hatch EVT. This appears like a proto specific board issue.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 7 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 30 May 2019 06:13:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Subrata Banik (Code Review)

6:17 a.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/32176/7/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32176/7/src/mainboard/google/hatch/variants/... PS7, Line 342: PLTRST

...

I haven't checked the interrupt storm. […]

As i understand you might need set PLTRST for proto alone and DEEP is final solution for EVT onwards ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 7 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 30 May 2019 06:17:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Krishna P Bhat D krishna.p.bhat.d@intel.com Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Krishna P Bhat D (Code Review)

11:22 a.m.

Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/32176/7/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32176/7/src/mainboard/google/hatch/variants/... PS7, Line 342: PLTRST

...

As i understand you might need set PLTRST for proto alone and DEEP is final solution for EVT onwards […]

I have checked on 1 hatch EVT board. More EVT boards have arrived, will check on few more and confirm the same.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 7 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 30 May 2019 11:22:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com Comment-In-Reply-To: Krishna P Bhat D krishna.p.bhat.d@intel.com Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Krishna P Bhat D (Code Review)

6 Jun 6 Jun

10:21 a.m.

Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/32176/7/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32176/7/src/mainboard/google/hatch/variants/... PS7, Line 342: PLTRST

...

I have checked on 1 hatch EVT board. […]

I further checked on EVT boards with pad reset config set to DEEP, I can see the issue reproducing. Hence we need to set the pad reset config as PLTRST for both proto and EVT systems.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 7 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 06 Jun 2019 10:21:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com Comment-In-Reply-To: Krishna P Bhat D krishna.p.bhat.d@intel.com Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Aamir Bohra (Code Review)

26 Jun 26 Jun

11:20 a.m.

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/32176/7/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32176/7/src/mainboard/google/hatch/variants/... PS7, Line 346: PAD_CFG_NF(GPP_G7, DN_20K, DEEP, NF1), we did not want to set the SD WP from FSP either right? and had it changed in FSP https://chrome-internal-review.googlesource.com/c/chromeos/third_party/intel....

So we should not be setting it to native pad mode here as this would force SD WP.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 7 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 26 Jun 2019 11:20:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Krishna P Bhat D (Code Review)

28 Jun 28 Jun

10:19 a.m.

Hello Subrata Banik, Aamir Bohra, Tim Wawrzynczak, Rizwan Qureshi, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32176

to look at the new patch set (#8).

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

mb/google/hatch: Update GPIO settings

This patch updates the following GPIO settings. 1. Set Native termination for GPP_G0 - G4 SD card pins. 2. Set GPP_B19 to NF1.

BUG=b:123907904 TEST=Verified SD card functionality on hatch. Checked for SD detection, transferred files to and from SD card.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/32176/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 8 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Krishna P Bhat D (Code Review)

10:22 a.m.

Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/#/c/32176/7/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/32176/7/src/mainboard/google/hatch/variants/... PS7, Line 346: PAD_CFG_NF(GPP_G7, DN_20K, DEEP, NF1),

...

we did not want to set the SD WP from FSP either right? and had it changed in FSP https://chrome-int […]

Yes Aamir. With SD WP Enable UPD disabled, we can leave the GPP_G7 pad as NC, FSP then does not configure it to native function.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 8 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 28 Jun 2019 10:22:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aamir Bohra aamir.bohra@intel.com Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

2:58 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 8 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 28 Jun 2019 14:58:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Aamir Bohra (Code Review)

2 Jul 2 Jul

7:17 a.m.

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 8 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Jul 2019 07:17:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

11:23 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/#/c/32176/8//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32176/8//COMMIT_MSG@7 PS8, Line 7: mb/google/hatch: Update GPIO settings Maybe more specific:

...

Update GPIO settings for SD card

https://review.coreboot.org/#/c/32176/8//COMMIT_MSG@12 PS8, Line 12: Where did you get this information from? Schematics? Data sheet?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 8 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Jul 2019 11:23:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Krishna P Bhat D (Code Review)

3 Jul 3 Jul

7:05 a.m.

Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings ......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/#/c/32176/8//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32176/8//COMMIT_MSG@7 PS8, Line 7: mb/google/hatch: Update GPIO settings

...

Maybe more specific: […]

Done

https://review.coreboot.org/#/c/32176/8//COMMIT_MSG@12 PS8, Line 12:

...

Where did you get this information from? Schematics? Data sheet?

Termination is recommendation for SD controller. GPP_B19 is being aligned here with FSP setting it to NF1.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 8 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 03 Jul 2019 07:05:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Krishna P Bhat D (Code Review)

7:05 a.m.

New subject: Change in ...coreboot[master]: mb/google/hatch: Update GPIO settings for SD card and SPI1 Chip select

Hello Subrata Banik, Aamir Bohra, Tim Wawrzynczak, Rizwan Qureshi, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32176

to look at the new patch set (#9).

Change subject: mb/google/hatch: Update GPIO settings for SD card and SPI1 Chip select ......................................................................

mb/google/hatch: Update GPIO settings for SD card and SPI1 Chip select

This patch updates the following GPIO settings. 1. Set Native termination for GPP_G0 - G4 SD card pins. 2. Set GPP_B19 to NF1.

BUG=b:123907904 TEST=Verified SD card functionality on hatch. Checked for SD detection, transferred files to and from SD card.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/32176/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 9 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

2:40 p.m.

New subject: Change in coreboot[master]: mb/google/hatch: Update GPIO settings for SD card and SPI1 Chip select

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings for SD card and SPI1 Chip select ......................................................................

Patch Set 9: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 9 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 03 Jul 2019 14:40:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

7 Jul 7 Jul

11:25 p.m.

New subject: Change in coreboot[master]: mb/google/hatch: Update GPIO settings for SD card and SPI1 Chip select

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32176 )

Change subject: mb/google/hatch: Update GPIO settings for SD card and SPI1 Chip select ......................................................................

mb/google/hatch: Update GPIO settings for SD card and SPI1 Chip select

This patch updates the following GPIO settings. 1. Set Native termination for GPP_G0 - G4 SD card pins. 2. Set GPP_B19 to NF1.

BUG=b:123907904 TEST=Verified SD card functionality on hatch. Checked for SD detection, transferred files to and from SD card.

Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Signed-off-by: Krishna Prasad Bhat krishna.p.bhat.d@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32176 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 7 insertions(+), 7 deletions(-)

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 56ae601..528ab02 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -99,8 +99,8 @@ PAD_CFG_NF(GPP_B17, NONE, DEEP, NF1), /* B18 : H1_SLAVE_SPI_MOSI_R */ PAD_CFG_NF(GPP_B18, NONE, DEEP, NF1), - /* B19 : GPP_B19 ==> NC */ - PAD_NC(GPP_B19, NONE), + /* B19 : Set to NF1 to match FSP setting it to NF1, i.e., GSPI1_CS0# */ + PAD_CFG_NF(GPP_B19, NONE, DEEP, NF1), /* B20 : PCH_SPI_FPMCU_CLK_R */ PAD_CFG_NF(GPP_B20, NONE, DEEP, NF1), /* B21 : PCH_SPI_FPMCU_MISO */ @@ -311,15 +311,15 @@ PAD_NC(GPP_F23, NONE),

-- To view, visit https://review.coreboot.org/c/coreboot/+/32176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2 Gerrit-Change-Number: 32176 Gerrit-PatchSet: 10 Gerrit-Owner: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Krishna P Bhat D krishna.p.bhat.d@intel.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1806

days inactive

1901

days old

coreboot-gerrit@coreboot.org

37 comments

8 participants

tags (0)

participants (8)

Aamir Bohra (Code Review)
Furquan Shaikh (Code Review)
Krishna P Bhat D (Code Review)
Martin Roth (Code Review)
Paul Menzel (Code Review)
Rizwan Qureshi (Code Review)
Subrata Banik (Code Review)
Tim Wawrzynczak (Code Review)