Krishna P Bhat D has uploaded this change for review.

View Change

mb/google/hatch: Update GPIO settings

This patch updates the following GPIO settings.
1. Set Native termination for GPP_G0 - G4 SD card pins.
2. Disable I2C #2 in devicetree.
3. Set GPP_B19, GPP_G7 to NF1.

BUG=b:123907904

Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2
Signed-off-by: Krishna Prasad Bhat <krishna.p.bhat.d@intel.com>
---
M src/mainboard/google/hatch/variants/baseboard/gpio.c
M src/mainboard/google/hatch/variants/hatch/overridetree.cb
M src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb
3 files changed, 11 insertions(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/32176/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c
index 4d1c87e..10f851b 100644
--- a/src/mainboard/google/hatch/variants/baseboard/gpio.c
+++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c
@@ -106,8 +106,8 @@
PAD_CFG_NF(GPP_B17, NONE, DEEP, NF1),
/* B18 : H1_SLAVE_SPI_MOSI_R */
PAD_CFG_NF(GPP_B18, NONE, DEEP, NF1),
- /* B19 : GPP_B19 ==> NC */
- PAD_NC(GPP_B19, NONE),
+ /* B19 : Set to NF1 */
+ PAD_CFG_NF(GPP_B19, NONE, DEEP, NF1),
/* B20 : PCH_SPI_FPMCU_CLK_R */
PAD_CFG_NF(GPP_B20, NONE, DEEP, NF1),
/* B21 : PCH_SPI_FPMCU_MISO */
@@ -329,21 +329,21 @@
PAD_NC(GPP_F23, NONE),

/* G0 : SD_CMD */
- PAD_CFG_NF(GPP_G0, NONE, DEEP, NF1),
+ PAD_CFG_NF(GPP_G0, NATIVE, DEEP, NF1),
/* G1 : SD_DATA0 */
- PAD_CFG_NF(GPP_G1, NONE, DEEP, NF1),
+ PAD_CFG_NF(GPP_G1, NATIVE, DEEP, NF1),
/* G2 : SD_DATA1 */
- PAD_CFG_NF(GPP_G2, NONE, DEEP, NF1),
+ PAD_CFG_NF(GPP_G2, NATIVE, DEEP, NF1),
/* G3 : SD_DATA2 */
- PAD_CFG_NF(GPP_G3, NONE, DEEP, NF1),
+ PAD_CFG_NF(GPP_G3, NATIVE, DEEP, NF1),
/* G4 : SD_DATA3 */
- PAD_CFG_NF(GPP_G4, NONE, DEEP, NF1),
+ PAD_CFG_NF(GPP_G4, NATIVE, DEEP, NF1),
/* G5 : SD_CD# */
PAD_CFG_NF(GPP_G5, NONE, DEEP, NF1),
/* G6 : SD_CLK */
PAD_CFG_NF(GPP_G6, NONE, DEEP, NF1),
- /* G7 : SD_WP => NC */
- PAD_NC(GPP_G7, DN_20K),
+ /* G7 : Set to NF1 */
+ PAD_CFG_NF(GPP_G7, NONE, DEEP, NF1),

/*
* H0 : HP_INT_L
diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb
index 28644d1..57daba2 100644
--- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb
@@ -69,7 +69,7 @@
device i2c 49 on end
end
end # I2C #1
- device pci 15.2 on
+ device pci 15.2 off
chip drivers/generic/gpio_keys
register "name" = ""PENH""
register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_HIGH(GPP_A8)"
diff --git a/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb b/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb
index 9b772c2..098bca6 100644
--- a/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb
@@ -54,7 +54,7 @@
device i2c 49 on end
end
end # I2C #1
- device pci 15.2 on
+ device pci 15.2 off
chip drivers/generic/gpio_keys
register "name" = ""PENH""
register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_HIGH(GPP_A8)"

To view, visit change 32176. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2
Gerrit-Change-Number: 32176
Gerrit-PatchSet: 1
Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d@intel.com>
Gerrit-MessageType: newchange