Change in ...coreboot[master]: TEST

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

HAOUAS Elyes (Code Review)

30 Mar 2019 30 Mar '19

1:20 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32128

Change subject: TEST ......................................................................

TEST

Change-Id: Id50a0d3c875c9d71a78b22cba1a0cc9410786c91 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/smaug/romstage.c 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/32128/1

diff --git a/src/mainboard/google/smaug/romstage.c b/src/mainboard/google/smaug/romstage.c index fd7c07f..affb04f 100644 --- a/src/mainboard/google/smaug/romstage.c +++ b/src/mainboard/google/smaug/romstage.c @@ -13,6 +13,7 @@ * GNU General Public License for more details. */

+/* Just for test */ #include <delay.h> #include <soc/addressmap.h> #include <device/i2c_simple.h>

Attachments:

attachment.htm (text/html — 2.2 KB)

Show replies by date

HAOUAS Elyes (Code Review)

30 Mar 30 Mar

1:27 p.m.

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32128 )

Change subject: TEST ......................................................................

Abandoned

HAOUAS Elyes (Code Review)

1:29 p.m.

HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/32128 )

Change subject: TEST ......................................................................

Restored

HAOUAS Elyes (Code Review)

1:29 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32128

to look at the new patch set (#2).

Change subject: TEST ......................................................................

TEST

Change-Id: Id50a0d3c875c9d71a78b22cba1a0cc9410786c91 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/32128/2

HAOUAS Elyes (Code Review)

3:18 p.m.

New subject: Change in ...coreboot[master]: TEST current toolchain

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32128

to look at the new patch set (#3).

Change subject: TEST current toolchain ......................................................................

TEST current toolchain

Change-Id: Id50a0d3c875c9d71a78b22cba1a0cc9410786c91 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/32128/3

HAOUAS Elyes (Code Review)

31 Mar 31 Mar

1:21 a.m.

New subject: Change in ...coreboot[master]: TEST current toolchain

HAOUAS Elyes has removed a vote on this change.

Change subject: TEST current toolchain ......................................................................

Removed Verified+1 by build bot (Jenkins) no-reply@coreboot.org

Martin Roth (Code Review)

12:11 p.m.

New subject: Change in ...coreboot[master]: TEST current toolchain

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32128 )

Change subject: TEST current toolchain ......................................................................

Patch Set 3:

Failure is the size of the smaug bootblock:

arm-eabi-ld.bfd: Bootblock exceeded its allotted size! (28K) arm-eabi-ld.bfd: verstage overlaps the previous region! make[2]: *** [src/arch/arm/Makefile.inc:70: /cb-build/coreboot-toolchain.0/GOOGLE_SMAUG/cbfs/fallback/bootblock.debug] Error 1 make[2]: Leaving directory '/home/coreboot/slave-root/workspace/coreboot-toolchain'

Interesting that we're seeing the failure here, but not on the current jenkins builds. I'll have to take a look at the previous toolchain commits to see what's going on. I did notice that sometimes jenkins is giving a validated +1 without running the toolchain build, so we might have to watch out for that.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id50a0d3c875c9d71a78b22cba1a0cc9410786c91 Gerrit-Change-Number: 32128 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-Comment-Date: Sun, 31 Mar 2019 17:11:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

12:22 p.m.

New subject: Change in ...coreboot[master]: TEST current toolchain

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32128 )

Change subject: TEST current toolchain ......................................................................

Patch Set 3:

...

Failure is the size of the smaug bootblock:

arm-eabi-ld.bfd: Bootblock exceeded its allotted size! (28K) arm-eabi-ld.bfd: verstage overlaps the previous region! make[2]: *** [src/arch/arm/Makefile.inc:70: /cb-build/coreboot-toolchain.0/GOOGLE_SMAUG/cbfs/fallback/bootblock.debug] Error 1 make[2]: Leaving directory '/home/coreboot/slave-root/workspace/coreboot-toolchain'

Interesting that we're seeing the failure here, but not on the current jenkins builds. I'll have to take a look at the previous toolchain commits to see what's going on. I did notice that sometimes jenkins is giving a validated +1 without running the toolchain build, so we might have to watch out for that.

yes, the latest toolchain compiled with no problem is https://review.coreboot.org/#/c/coreboot/+/32028/

1- the problem is probably coming from a commit after this one, but I didn't find it

2- we probably need to upgrade the builder toolchain each time to set using the same as the tree. as you can see for exmple : https://review.coreboot.org/#/c/coreboot/+/31554/ https://review.coreboot.org/#/c/coreboot/+/31526/ https://review.coreboot.org/#/c/coreboot/+/31528/ spotted using IASL 20190215. so if Jenkins didn't use the same toolchain, we can merge by mistake not good changes

what is your thought ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id50a0d3c875c9d71a78b22cba1a0cc9410786c91 Gerrit-Change-Number: 32128 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-Comment-Date: Sun, 31 Mar 2019 17:22:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

2 Apr 2 Apr

12:28 p.m.

New subject: Change in ...coreboot[master]: TEST current toolchain

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32128 )

Change subject: TEST current toolchain ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/32128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id50a0d3c875c9d71a78b22cba1a0cc9410786c91 Gerrit-Change-Number: 32128 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

Martin Roth (Code Review)

12:35 p.m.

New subject: Change in ...coreboot[master]: TEST current toolchain

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32128 )

Change subject: TEST current toolchain ......................................................................

Patch Set 3:

My thought is that we should hold of on merging toolchain changes unless they're actually needed to fix an error. It's a fair amount of work to update things on the builders, so I'd prefer to only do it a couple times a year instead of whenever a toolchain change goes in.

This is in no way unappreciative of everyone's work to keep the toolchains up-to-date, It would just be easier to maintain if we merged toolchain changes at planned times - after we do releases, for example.

Regarding the failure on Smaug, i think it was actually a change that went into the tree AFTER the last toolchain update.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id50a0d3c875c9d71a78b22cba1a0cc9410786c91 Gerrit-Change-Number: 32128 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Apr 2019 17:35:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

1:48 p.m.

New subject: Change in ...coreboot[master]: TEST current toolchain

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32128 )

Change subject: TEST current toolchain ......................................................................

Patch Set 3:

...

My thought is that we should hold of on merging toolchain changes unless they're actually needed to fix an error. It's a fair amount of work to update things on the builders, so I'd prefer to only do it a couple times a year instead of whenever a toolchain change goes in.

This is in no way unappreciative of everyone's work to keep the toolchains up-to-date, It would just be easier to maintain if we merged toolchain changes at planned times - after we do releases, for example.

completely agree

...

Regarding the failure on Smaug, i think it was actually a change that went into the tree AFTER the last toolchain update.

Yes, I think too, but I didn't find any thing that may affect the Bootblock size.

Maybe Julius can help on this: "src/soc/nvidia/tegra210/Makefile.inc:115: warning: overriding recipe for target '/cb-build/coreboot-toolchain.0/GOOGLE_SMAUG/cbfs/fallback/bootblock.raw.elf'" https://qa.coreboot.org/job/coreboot-toolchain/541/testReport/board/chromeos...

-- To view, visit https://review.coreboot.org/c/coreboot/+/32128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id50a0d3c875c9d71a78b22cba1a0cc9410786c91 Gerrit-Change-Number: 32128 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Apr 2019 18:48:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

1:50 p.m.

New subject: Change in ...coreboot[master]: TEST current toolchain

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32128 )

Change subject: TEST current toolchain ......................................................................

Patch Set 3:

...

My thought is that we should hold of on merging toolchain changes unless they're actually needed to fix an error. It's a fair amount of work to update things on the builders, so I'd prefer to only do it a couple times a year instead of whenever a toolchain change goes in.

This is in no way unappreciative of everyone's work to keep the toolchains up-to-date, It would just be easier to maintain if we merged toolchain changes at planned times - after we do releases, for example.

completely agree

...

Regarding the failure on Smaug, i think it was actually a change that went into the tree AFTER the last toolchain update.

Yes, I think too, but I didn't find any thing that may affect the Bootblock size.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id50a0d3c875c9d71a78b22cba1a0cc9410786c91 Gerrit-Change-Number: 32128 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Apr 2019 18:50:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Julius Werner (Code Review)

2:27 p.m.

New subject: Change in ...coreboot[master]: TEST current toolchain

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32128 )

Change subject: TEST current toolchain ......................................................................

Patch Set 3:

...

Maybe Julius can help on this: "src/soc/nvidia/tegra210/Makefile.inc:115: warning: overriding recipe for target '/cb-build/coreboot-toolchain.0/GOOGLE_SMAUG/cbfs/fallback/bootblock.raw.elf'" https://qa.coreboot.org/job/coreboot-toolchain/541/testReport/board/chromeos...

Yeah, I think that's an error / outdated line in the Makefile, actually. You could just remove the bootblock.raw.elf rule from src/soc/nvidia/tegra210/Makefile.inc. The default rule from the toplevel Makefile.inc should do the same thing.

However, I don't think that's the real error here, you're just blowing the bootblock budget. There is more free memory left in the T210 memlayout, you just have to shuffle it around a bit then you can increase the bootblock size.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id50a0d3c875c9d71a78b22cba1a0cc9410786c91 Gerrit-Change-Number: 32128 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin Roth martinroth@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Apr 2019 19:27:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2173

days inactive

2176

days old

coreboot-gerrit@coreboot.org

12 comments

3 participants

tags (0)

participants (3)

HAOUAS Elyes (Code Review)
Julius Werner (Code Review)
Martin Roth (Code Review)