My thought is that we should hold of on merging toolchain changes
> unless they're actually needed to fix an error. It's a fair
> amount
> of work to update things on the builders, so I'd prefer to only
> do
> it a couple times a year instead of whenever a toolchain change
> goes in.
>
> This is in no way unappreciative of everyone's work to keep the
> toolchains up-to-date, It would just be easier to maintain if we
> merged toolchain changes at planned times - after we do releases,
> for example.

completely agree
 
> Regarding the failure on Smaug, i think it was actually a change
> that went into the tree AFTER the last toolchain update.

Yes, I think too, but I didn't find any thing that may affect the
Bootblock size.

Maybe Julius can help on this:
"src/soc/nvidia/tegra210/Makefile.inc:115: warning: overriding
recipe for target '/cb-build/coreboot-toolchain.0/GOOGLE_SMAUG/cbfs/fallback/bootblock.raw.elf'"
https://qa.coreboot.org/job/coreboot-toolchain/541/testReport/board/chromeos/GOOGLE_SMAUG/

View Change

To view, visit change 32128. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id50a0d3c875c9d71a78b22cba1a0cc9410786c91
Gerrit-Change-Number: 32128
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Martin Roth <martinroth@google.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 02 Apr 2019 18:50:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment