Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43829 )
Change subject: util/mb/google/volteer: Delete dptf.asl ......................................................................
util/mb/google/volteer: Delete dptf.asl
Since we are not using raw ASL files anymore for DPTF, delete the template file too, so that it does not keep getting added for new board variants.
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: Ia128989c64b8c02759c326431b4ee30fd2b483e4 --- D util/mainboard/google/volteer/template/include/variant/acpi/dptf.asl 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/43829/1
diff --git a/util/mainboard/google/volteer/template/include/variant/acpi/dptf.asl b/util/mainboard/google/volteer/template/include/variant/acpi/dptf.asl deleted file mode 100644 index 189cafe..0000000 --- a/util/mainboard/google/volteer/template/include/variant/acpi/dptf.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/dptf.asl>
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43829 )
Change subject: util/mb/google/volteer: Delete dptf.asl ......................................................................
Patch Set 1:
Zhuohao, all of the DPTF tables are now generated at runtime, see CB:43422 so this is no longer necessary
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43829 )
Change subject: util/mb/google/volteer: Delete dptf.asl ......................................................................
Patch Set 1: Code-Review+2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43829 )
Change subject: util/mb/google/volteer: Delete dptf.asl ......................................................................
Patch Set 1: Code-Review+2
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43829 )
Change subject: util/mb/google/volteer: Delete dptf.asl ......................................................................
Patch Set 1: Code-Review+2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43829 )
Change subject: util/mb/google/volteer: Delete dptf.asl ......................................................................
Patch Set 1:
"Patches can be ‘Fast-tracked’ and submitted in under 24 hours with the agreement of at least 3 +2 votes." (https://doc.coreboot.org/getting_started/gerrit_guidelines.html)
Paul Fagerburg has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43829 )
Change subject: util/mb/google/volteer: Delete dptf.asl ......................................................................
util/mb/google/volteer: Delete dptf.asl
Since we are not using raw ASL files anymore for DPTF, delete the template file too, so that it does not keep getting added for new board variants.
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: Ia128989c64b8c02759c326431b4ee30fd2b483e4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43829 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Caveh Jalali caveh@chromium.org --- D util/mainboard/google/volteer/template/include/variant/acpi/dptf.asl 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved Angel Pons: Looks good to me, approved Paul Fagerburg: Looks good to me, approved
diff --git a/util/mainboard/google/volteer/template/include/variant/acpi/dptf.asl b/util/mainboard/google/volteer/template/include/variant/acpi/dptf.asl deleted file mode 100644 index 189cafe..0000000 --- a/util/mainboard/google/volteer/template/include/variant/acpi/dptf.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/dptf.asl>
-
Angel Pons (Code Review) -
Caveh Jalali (Code Review)
-
Paul Fagerburg (Code Review)
-
Tim Wawrzynczak (Code Review)