Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43828 )
Change subject: mb/google/volteer: Remove unused dptf.asl files ......................................................................
mb/google/volteer: Remove unused dptf.asl files
In the middle of the Great DPTF Refactor of 2020, new volteer variants were added, but their dptf.asl files are no longer used, so delete them.
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I52f2042aa870a29026eb9fe122340ad07654e706 --- D src/mainboard/google/volteer/variants/delbin/include/variant/acpi/dptf.asl D src/mainboard/google/volteer/variants/terrador/include/variant/acpi/dptf.asl D src/mainboard/google/volteer/variants/volteer2/include/variant/acpi/dptf.asl D src/mainboard/google/volteer/variants/voxel/include/variant/acpi/dptf.asl 4 files changed, 0 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/43828/1
diff --git a/src/mainboard/google/volteer/variants/delbin/include/variant/acpi/dptf.asl b/src/mainboard/google/volteer/variants/delbin/include/variant/acpi/dptf.asl deleted file mode 100644 index 189cafe..0000000 --- a/src/mainboard/google/volteer/variants/delbin/include/variant/acpi/dptf.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/dptf.asl> diff --git a/src/mainboard/google/volteer/variants/terrador/include/variant/acpi/dptf.asl b/src/mainboard/google/volteer/variants/terrador/include/variant/acpi/dptf.asl deleted file mode 100644 index 189cafe..0000000 --- a/src/mainboard/google/volteer/variants/terrador/include/variant/acpi/dptf.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/dptf.asl> diff --git a/src/mainboard/google/volteer/variants/volteer2/include/variant/acpi/dptf.asl b/src/mainboard/google/volteer/variants/volteer2/include/variant/acpi/dptf.asl deleted file mode 100644 index 189cafe..0000000 --- a/src/mainboard/google/volteer/variants/volteer2/include/variant/acpi/dptf.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/dptf.asl> diff --git a/src/mainboard/google/volteer/variants/voxel/include/variant/acpi/dptf.asl b/src/mainboard/google/volteer/variants/voxel/include/variant/acpi/dptf.asl deleted file mode 100644 index 189cafe..0000000 --- a/src/mainboard/google/volteer/variants/voxel/include/variant/acpi/dptf.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/dptf.asl>
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43828 )
Change subject: mb/google/volteer: Remove unused dptf.asl files ......................................................................
Patch Set 1: Code-Review+2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43828 )
Change subject: mb/google/volteer: Remove unused dptf.asl files ......................................................................
Patch Set 1: Code-Review+2
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43828 )
Change subject: mb/google/volteer: Remove unused dptf.asl files ......................................................................
Patch Set 1: Code-Review+2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43828 )
Change subject: mb/google/volteer: Remove unused dptf.asl files ......................................................................
Patch Set 1:
"Patches can be ‘Fast-tracked’ and submitted in under 24 hours with the agreement of at least 3 +2 votes." (https://doc.coreboot.org/getting_started/gerrit_guidelines.html)
Paul Fagerburg has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43828 )
Change subject: mb/google/volteer: Remove unused dptf.asl files ......................................................................
mb/google/volteer: Remove unused dptf.asl files
In the middle of the Great DPTF Refactor of 2020, new volteer variants were added, but their dptf.asl files are no longer used, so delete them.
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I52f2042aa870a29026eb9fe122340ad07654e706 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43828 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Caveh Jalali caveh@chromium.org --- D src/mainboard/google/volteer/variants/delbin/include/variant/acpi/dptf.asl D src/mainboard/google/volteer/variants/terrador/include/variant/acpi/dptf.asl D src/mainboard/google/volteer/variants/volteer2/include/variant/acpi/dptf.asl D src/mainboard/google/volteer/variants/voxel/include/variant/acpi/dptf.asl 4 files changed, 0 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved Angel Pons: Looks good to me, approved Paul Fagerburg: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/delbin/include/variant/acpi/dptf.asl b/src/mainboard/google/volteer/variants/delbin/include/variant/acpi/dptf.asl deleted file mode 100644 index 189cafe..0000000 --- a/src/mainboard/google/volteer/variants/delbin/include/variant/acpi/dptf.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/dptf.asl> diff --git a/src/mainboard/google/volteer/variants/terrador/include/variant/acpi/dptf.asl b/src/mainboard/google/volteer/variants/terrador/include/variant/acpi/dptf.asl deleted file mode 100644 index 189cafe..0000000 --- a/src/mainboard/google/volteer/variants/terrador/include/variant/acpi/dptf.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/dptf.asl> diff --git a/src/mainboard/google/volteer/variants/volteer2/include/variant/acpi/dptf.asl b/src/mainboard/google/volteer/variants/volteer2/include/variant/acpi/dptf.asl deleted file mode 100644 index 189cafe..0000000 --- a/src/mainboard/google/volteer/variants/volteer2/include/variant/acpi/dptf.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/dptf.asl> diff --git a/src/mainboard/google/volteer/variants/voxel/include/variant/acpi/dptf.asl b/src/mainboard/google/volteer/variants/voxel/include/variant/acpi/dptf.asl deleted file mode 100644 index 189cafe..0000000 --- a/src/mainboard/google/volteer/variants/voxel/include/variant/acpi/dptf.asl +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <baseboard/acpi/dptf.asl>
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43828 )
Change subject: mb/google/volteer: Remove unused dptf.asl files ......................................................................
Patch Set 2:
Patch Set 1:
"Patches can be ‘Fast-tracked’ and submitted in under 24 hours with the agreement of at least 3 +2 votes." (https://doc.coreboot.org/getting_started/gerrit_guidelines.html)
We want to clarify that rule, refer to CB:43484 for details. IMHO, unless necessary to unbreak something, I prefer to wait 24 hours before submitting stuff.
-
Angel Pons (Code Review) -
Caveh Jalali (Code Review)
-
Paul Fagerburg (Code Review)
-
Tim Wawrzynczak (Code Review)