Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39980 )
Change subject: soc/intel/skylake: vr_config: enable PSI3 and PSI4 by default
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39980/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39980/3//COMMIT_MSG@13
PS3, Line 13:
Mention that in 2015 there were problems in FSP?
ACK
https://review.coreboot.org/c/coreboot/+/39980/3//COMMIT_MSG@18
PS3, Line 18: Boards that have a domain_vr_config and set their specific settings are
I'd like to have a way to dump the vendor information from the vendor image and/or read it by inteltool. Nico tried to read the VR mailbox without success. I tried to check the MSR 0x601 but that is 0x00
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39980
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b5fd9fb3b9b89e80c47f15d706e2dd62dcc0748
Gerrit-Change-Number: 39980
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Matthew Garrett
mjg59@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 01 Apr 2020 18:12:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment