Change in coreboot[master]: mb/google/dedede/var/sasuke: Update GPIO configuration

[shkim (Code Review)]

Hello SH Kim,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/48624

to review the following change.

Change subject: mb/google/dedede/var/sasuke: Update GPIO configuration
......................................................................

mb/google/dedede/var/sasuke: Update GPIO configuration

This change updates GPIO configuration for sasuke.

BUG=b:172104731

Change-Id: I6c2c6775ab236462ec3410746d5d0f183831f3e4
Signed-off-by: Seunghwan Kim 
---
A src/mainboard/google/dedede/variants/sasuke/Makefile.inc
A src/mainboard/google/dedede/variants/sasuke/gpio.c
2 files changed, 80 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/48624/1

diff --git a/src/mainboard/google/dedede/variants/sasuke/Makefile.inc b/src/mainboard/google/dedede/variants/sasuke/Makefile.inc
new file mode 100644
index 0000000..eb2c9bc
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/sasuke/Makefile.inc
@@ -0,0 +1,3 @@
+## SPDX-License-Identifier: GPL-2.0-or-later
+
+ramstage-y += gpio.c
diff --git a/src/mainboard/google/dedede/variants/sasuke/gpio.c b/src/mainboard/google/dedede/variants/sasuke/gpio.c
new file mode 100644
index 0000000..070dd95
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/sasuke/gpio.c
@@ -0,0 +1,77 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#include <baseboard/gpio.h>
+#include <baseboard/variants.h>
+
+/* Pad configuration in ramstage*/
+static const struct pad_config gpio_table[] = {
+	/* A10 : WWAN_EN */
+	PAD_CFG_GPO(GPP_A10, 0, DEEP),
+	/* A11 : TOUCH_RPT_EN ==> NC */
+	PAD_NC(GPP_A11, NONE),
+	/* A18 : USB_OC0_N ==> USB_A0_OC_ODL */
+	PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1),
+
+	/* B7  : PCIE_CLKREQ2_N ==> WWAN_SAR_DETECT_ODL*/
+	PAD_CFG_GPI_IRQ_WAKE(GPP_B7, NONE, DEEP, LEVEL, INVERT),
+	/* B8  : WLAN_CLKREQ_ODL ==> NC */
+	PAD_NC(GPP_B8, NONE),
+
+	/* C18 : AP_I2C_EMR_SDA ==> NC */
+	PAD_NC(GPP_C18, NONE),
+	/* C19 : AP_I2C_EMR_SCL ==> NC */
+	PAD_NC(GPP_C19, NONE),
+
+	/* D0  : WWAN_HOST_WAKE ==> WWAN_WDISABLE_L */
+	PAD_CFG_GPO(GPP_D0, 1, DEEP),
+	/* D1  : WLAN_PERST_L ==> NC */
+	PAD_NC(GPP_D1, NONE),
+	/* D3  : WLAN_PCIE_WAKE_ODL ==> NC */
+	PAD_NC(GPP_D3, NONE),
+	/* D4  : TOUCH_INT_ODL ==> NC */
+	PAD_NC(GPP_D4, NONE),
+	/* D5  : TOUCH_RESET_L ==> NC */
+	PAD_NC(GPP_D5, NONE),
+	/* D6  : EN_PP3300_TOUCH_S0 ==> NC */
+	PAD_NC(GPP_D6, NONE),
+	/* D12 : WCAM_RST_L ==> NC */
+	PAD_NC(GPP_D12, NONE),
+	/* D14 : EN_PP1200_CAMERA ==> NC */
+	PAD_NC(GPP_D14, NONE),
+	/* D15 : UCAM_RST_L ==> NC */
+	PAD_NC(GPP_D15, NONE),
+	/* D19 : WWAN_WLAN_COEX1 ==> NC */
+	PAD_NC(GPP_D19, NONE),
+	/* D20 : WWAN_WLAN_COEX2 ==> NC */
+	PAD_NC(GPP_D20, NONE),
+	/* D21 : WWAN_WLAN_COEX3 ==> NC */
+	PAD_NC(GPP_D21, NONE),
+
+	/* E2  : CLK_24M_WCAM ==> NC */
+	PAD_NC(GPP_E2, NONE),
+
+	/* G7  : SD_SDIO_WP ==> NC */
+	PAD_NC(GPP_G7, NONE),
+
+	/* H4  : AP_I2C_TS_SDA ==> NC */
+	PAD_NC(GPP_H4, NONE),
+	/* H5  : AP_I2C_TS_SCL ==> NC */
+	PAD_NC(GPP_H5, NONE),
+	/* H6  : AP_I2C_CAM_SDA ==> NC */
+	PAD_NC(GPP_H6, NONE),
+	/* H7  : AP_I2C_CAM_SCL ==> NC */
+	PAD_NC(GPP_H7, NONE),
+	/* H17 : WWAN_RST_L */
+	PAD_CFG_GPO(GPP_H17, 1, DEEP),
+
+	/* S2  : DMIC1_CLK ==> NC */
+	PAD_NC(GPP_S2, NONE),
+	/* S3  : DMIC1_DATA ==> NC */
+	PAD_NC(GPP_S3, NONE),
+};
+
+const struct pad_config *variant_override_gpio_table(size_t *num)
+{
+	*num = ARRAY_SIZE(gpio_table);
+	return gpio_table;
+}

[Raymond Chung (Code Review)]

Raymond Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48624 )

Change subject: mb/google/dedede/var/sasuke: Update GPIO configuration
......................................................................

Patch Set 1: Code-Review+1

[shkim (Code Review)]

shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48624 )

Change subject: mb/google/dedede/var/sasuke: Update GPIO configuration
......................................................................

Patch Set 1:

Can we merge this change?

[shkim (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Henry Sun, Raymond Chung, Paul Menzel, SH Kim, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48624

to look at the new patch set (#2).

Change subject: mb/google/dedede/var/sasuke: Update GPIO configuration
......................................................................

mb/google/dedede/var/sasuke: Update GPIO configuration

This change updates GPIO configuration for sasuke.

BUG=b:172104731

Change-Id: I6c2c6775ab236462ec3410746d5d0f183831f3e4
Signed-off-by: Seunghwan Kim 
---
A src/mainboard/google/dedede/variants/sasuke/Makefile.inc
A src/mainboard/google/dedede/variants/sasuke/gpio.c
2 files changed, 88 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/48624/2

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48624 )

Change subject: mb/google/dedede/var/sasuke: Update GPIO configuration
......................................................................

Patch Set 2:

As mentioned by Justin in the subsequent CL, please split the CL into multiple CLs for each individual device configuration. Also configure the corresponding GPIOs along with that device tree configuration.

[shkim (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Henry Sun, Raymond Chung, Paul Menzel, SH Kim, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48624

to look at the new patch set (#3).

Change subject: mb/google/dedede/var/sasuke: Update GPIO configuration
......................................................................

mb/google/dedede/var/sasuke: Update GPIO configuration

This change updates GPIO configuration for sasuke.

BUG=b:172104731

Change-Id: I6c2c6775ab236462ec3410746d5d0f183831f3e4
Signed-off-by: Seunghwan Kim 
---
A src/mainboard/google/dedede/variants/sasuke/Makefile.inc
A src/mainboard/google/dedede/variants/sasuke/gpio.c
2 files changed, 80 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/48624/3

[shkim (Code Review)]

shkim has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48624 )

Change subject: mb/google/dedede/var/sasuke: Update GPIO configuration
......................................................................

Abandoned