Hello SH Kim,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/48625
to review the following change.
Change subject: mb/google/dedede/var/sasuke: Update overridetree.cb ......................................................................
mb/google/dedede/var/sasuke: Update overridetree.cb
This change updates overridtree.cb based on latest sasuke schematics.
BUG=b:172104731
Change-Id: I74862326998fc2115daee616e09ec7a54d1e1607 Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com --- M src/mainboard/google/dedede/variants/sasuke/overridetree.cb 1 file changed, 73 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/48625/1
diff --git a/src/mainboard/google/dedede/variants/sasuke/overridetree.cb b/src/mainboard/google/dedede/variants/sasuke/overridetree.cb index 69ea1e1..1c9033c 100644 --- a/src/mainboard/google/dedede/variants/sasuke/overridetree.cb +++ b/src/mainboard/google/dedede/variants/sasuke/overridetree.cb @@ -1,6 +1,7 @@ chip soc/intel/jasperlake
# USB Port Configuration + register "usb2_ports[4]" = "USB2_PORT_EMPTY" register "usb2_ports[5]" = "USB2_PORT_MID(OC_SKIP)" # Camera
# Intel Common SoC Config @@ -48,11 +49,79 @@ }, }" device domain 0 on - device pci 14.0 on end - device pci 15.0 on end + device pci 14.0 on + chip drivers/usb/acpi + register "desc" = ""Root Hub"" + register "type" = "UPC_TYPE_HUB" + device usb 0.0 on + chip drivers/usb/acpi + register "desc" = ""UFCamera"" + register "type" = "UPC_TYPE_INTERNAL" + register "has_power_resource" = "1" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D13)" + register "enable_delay_ms" = "20" + device usb 2.5 on end + end + chip drivers/usb/acpi + register "desc" = ""LTE"" + register "type" = "UPC_TYPE_INTERNAL" + register "has_power_resource" = "1" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H17)" + register "reset_off_delay_ms" = "10" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A10)" + register "enable_delay_ms" = "20" + device usb 3.3 on end + end + end + end + end # USB xHCI + device pci 15.0 on + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)" + register "wake" = "GPE0_DW0_03" + register "probed" = "1" + device i2c 15 on end + end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_B3_IRQ)" + register "generic.wake" = "GPE0_DW0_03" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 0x2c on end + end + end # I2C 0 device pci 15.2 on end device pci 1c.7 on end - device pci 19.0 on end - device pci 1f.3 on end + device pci 19.0 on + chip drivers/i2c/da7219 + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_D16)" + register "btn_cfg" = "50" + register "mic_det_thr" = "500" + register "jack_ins_deb" = "20" + register "jack_det_rate" = ""32ms_64ms"" + register "jack_rem_deb" = "1" + register "a_d_btn_thr" = "0xa" + register "d_b_btn_thr" = "0x16" + register "b_c_btn_thr" = "0x21" + register "c_mic_btn_thr" = "0x3e" + register "btn_avg" = "4" + register "adc_1bit_rpt" = "1" + register "micbias_lvl" = "2600" + register "mic_amp_in_sel" = ""diff"" + device i2c 1a on end + end + end #I2C 4 + device pci 1f.3 on + chip drivers/generic/max98357a + register "hid" = ""MX98357A"" + register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D17)" + device generic 0 on end + end + end # Intel HDA + end end
Raymond Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48625 )
Change subject: mb/google/dedede/var/sasuke: Update overridetree.cb ......................................................................
Patch Set 1: Code-Review+1
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Henry Sun, Raymond Chung, Paul Menzel, SH Kim, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48625
to look at the new patch set (#2).
Change subject: mb/google/dedede/var/sasuke: Update overridetree.cb ......................................................................
mb/google/dedede/var/sasuke: Update overridetree.cb
This change updates overridtree.cb based on latest sasuke schematics.
BUG=b:172104731
Change-Id: I74862326998fc2115daee616e09ec7a54d1e1607 Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com --- M src/mainboard/google/dedede/variants/sasuke/overridetree.cb 1 file changed, 75 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/48625/2
Raymond Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48625 )
Change subject: mb/google/dedede/var/sasuke: Update overridetree.cb ......................................................................
Patch Set 2: Code-Review+1
shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48625 )
Change subject: mb/google/dedede/var/sasuke: Update overridetree.cb ......................................................................
Patch Set 2:
Can we merge this change?
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Henry Sun, Raymond Chung, Paul Menzel, SH Kim, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48625
to look at the new patch set (#3).
Change subject: mb/google/dedede/var/sasuke: Update overridetree.cb ......................................................................
mb/google/dedede/var/sasuke: Update overridetree.cb
This change updates overridtree.cb based on latest sasuke schematics.
BUG=b:172104731
Change-Id: I74862326998fc2115daee616e09ec7a54d1e1607 Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com --- M src/mainboard/google/dedede/variants/sasuke/overridetree.cb 1 file changed, 114 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/48625/3
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48625 )
Change subject: mb/google/dedede/var/sasuke: Update overridetree.cb ......................................................................
Patch Set 3:
There's a lot going on in this change. Ideally there would be separate commits for the different areas (USB, audio, I2C clocking)
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48625 )
Change subject: mb/google/dedede/var/sasuke: Update overridetree.cb ......................................................................
Patch Set 3:
(8 comments)
https://review.coreboot.org/c/coreboot/+/48625/3/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/sasuke/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48625/3/src/mainboard/google/dedede... PS3, Line 2: # Disable HPD for DDI ports B/C Why?
https://review.coreboot.org/c/coreboot/+/48625/3/src/mainboard/google/dedede... PS3, Line 6: # Disable DDC for DDI ports B/C Why?
https://review.coreboot.org/c/coreboot/+/48625/3/src/mainboard/google/dedede... PS3, Line 40: .pre_emp_bias = 0x4, What does 0x4 correspond to? Can you please add that in the jasperlake/include/soc/usb.h file?
https://review.coreboot.org/c/coreboot/+/48625/3/src/mainboard/google/dedede... PS3, Line 84: .scl_lcnt = 200, : .scl_hcnt = 120, What is the measured I2C bus frequency with this high and low count?
https://review.coreboot.org/c/coreboot/+/48625/3/src/mainboard/google/dedede... PS3, Line 93: register "desc" = ""Root Hub"" : register "type" = "UPC_TYPE_HUB" No need to override. This is the same as in baseboard devicetree.
https://review.coreboot.org/c/coreboot/+/48625/3/src/mainboard/google/dedede... PS3, Line 100: register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D13)" : register "enable_delay_ms" = "20" Does the camera needs to be turned off during S0ix entry and turned on during S0ix exit?
https://review.coreboot.org/c/coreboot/+/48625/3/src/mainboard/google/dedede... PS3, Line 136: device pci 15.2 on end Turn off device 15.3 if you are not planning to use MIPI Camera.
https://review.coreboot.org/c/coreboot/+/48625/3/src/mainboard/google/dedede... PS3, Line 137: device pci 1c.7 on end Are you planning to use a discrete WiFi solution? If not, this can be turned off too.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Henry Sun, Raymond Chung, Paul Menzel, SH Kim, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48625
to look at the new patch set (#4).
Change subject: mb/google/dedede/var/sasuke: Update overridetree.cb ......................................................................
mb/google/dedede/var/sasuke: Update overridetree.cb
This change updates overridtree.cb based on latest sasuke schematics.
BUG=b:172104731
Change-Id: I74862326998fc2115daee616e09ec7a54d1e1607 Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com --- M src/mainboard/google/dedede/variants/sasuke/overridetree.cb 1 file changed, 107 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/48625/4
shkim has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48625 )
Change subject: mb/google/dedede/var/sasuke: Update overridetree.cb ......................................................................
Abandoned
-
Justin TerAvest (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Raymond Chung (Code Review)
-
shkim (Code Review)