Change in coreboot[master]: drivers/intel/gma/edid: Measure execution time of EDID read function

[Paul Menzel (Code Review)]

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38646 )

Change subject: drivers/intel/gma/edid: Measure execution time of EDID read function
......................................................................

drivers/intel/gma/edid: Measure execution time of EDID read function

Getting more data, it might turn out, that storing the EDID data in CBFS
might save some time.

Change-Id: I4c3672ef85bfc2d206620e689626573e04a0f63b
Signed-off-by: Paul Menzel 
---
M src/drivers/intel/gma/edid.c
1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/38646/1

diff --git a/src/drivers/intel/gma/edid.c b/src/drivers/intel/gma/edid.c
index 7e6c840..6885f98 100644
--- a/src/drivers/intel/gma/edid.c
+++ b/src/drivers/intel/gma/edid.c
@@ -15,6 +15,7 @@
 #include <device/mmio.h>
 #include <console/console.h>
 #include <delay.h>
+#include <timer.h>

#include "i915_reg.h"
 #include "edid.h"
@@ -66,10 +67,12 @@
 void intel_gmbus_read_edid(u8 *mmio, u8 bus, u8 slave, u8 *edid, u32 edid_size)
 {
    unsigned int i;
+	struct stopwatch sw;

slave &= 0x7f;
    edid_size &= 0x1fc;

+	stopwatch_init(&sw);
    wait_rdy(mmio);
    /* 100 KHz, hold 0ns,  */
    write32(GMBUS0_ADDR, bus);
@@ -107,4 +110,6 @@
    	if ((i & 0xf) == 0xf)
    		printk (BIOS_SPEW, "\n");
    }
+	printk(BIOS_DEBUG, "%s finished in %lu msecs\n", __func__,
+			stopwatch_duration_msecs(&sw));
 }

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38646 )

Change subject: drivers/intel/gma/edid: Measure execution time of EDID read function
......................................................................

Patch Set 1: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/38646/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38646/1//COMMIT_MSG@7 
PS1, Line 7: Measure execution time of EDID read function
Measure time to read an EDID

https://review.coreboot.org/c/coreboot/+/38646/1//COMMIT_MSG@9 
PS1, Line 9: Getting more data, it might turn out, that storing the EDID data in CBFS
           : might save some time.
What do you mean?

Change in coreboot[master]: drivers/intel/gma/edid: Measure time to read an EDID

[Paul Menzel (Code Review)]

Hello build bot (Jenkins), Nico Huber, Peter Lemenkov, Angel Pons, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38646

to look at the new patch set (#4).

Change subject: drivers/intel/gma/edid: Measure time to read an EDID
......................................................................

drivers/intel/gma/edid: Measure time to read an EDID

Getting more data, it might turn out, that storing the EDID data in CBFS
might save some time.

Change-Id: I4c3672ef85bfc2d206620e689626573e04a0f63b
Signed-off-by: Paul Menzel 
---
M src/drivers/intel/gma/edid.c
1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/38646/4

Change in coreboot[master]: drivers/intel/gma/edid: Measure time to read an EDID

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38646 )

Change subject: drivers/intel/gma/edid: Measure time to read an EDID
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38646/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38646/1//COMMIT_MSG@7 
PS1, Line 7: Measure execution time of EDID read function
> Measure time to read an EDID

Done

https://review.coreboot.org/c/coreboot/+/38646/1//COMMIT_MSG@9 
PS1, Line 9: Getting more data, it might turn out, that storing the EDID data in CBFS
           : might save some time.
> What do you mean?

If reading EDID takes 15 ms, it might make sense to cache it. First we have to measure the time though.

[XS] Change in coreboot[master]: drivers/intel/gma/edid: Measure time to read an EDID

[Martin L Roth (Code Review)]

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38646?usp=email )

Change subject: drivers/intel/gma/edid: Measure time to read an EDID
......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.