Change in coreboot[master]: drivers/intel/gma/edid: Use unsigned type for count variable

List overview All Threads
Download

newer

older

[M] Change in coreboot[master]:...

Change in coreboot[master]:...

Paul Menzel (Code Review)

30 Jan 2020 30 Jan '20

8:13 a.m.

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38645 )

Change subject: drivers/intel/gma/edid: Use unsigned type for count variable ......................................................................

drivers/intel/gma/edid: Use unsigned type for count variable

No real difference in the assembly though.

@@ -799,8 +799,8 @@ .string "i" .byte 0x1 .byte 0x44 - .byte 0x6 - .long 0x4d + .byte 0xf + .long 0x60 .long .LLST25 .long .LVUS25 .uleb128 0xe

Change-Id: I340a2752f955e5e4d2198a81408b3663b1488b80 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/drivers/intel/gma/edid.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/38645/1

diff --git a/src/drivers/intel/gma/edid.c b/src/drivers/intel/gma/edid.c index 4d4aec3..7e6c840 100644 --- a/src/drivers/intel/gma/edid.c +++ b/src/drivers/intel/gma/edid.c @@ -65,7 +65,7 @@

void intel_gmbus_read_edid(u8 *mmio, u8 bus, u8 slave, u8 *edid, u32 edid_size) { - int i; + unsigned int i;

slave &= 0x7f; edid_size &= 0x1fc;

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Angel Pons (Code Review)

30 Jan 30 Jan

11:44 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38645 )

Change subject: drivers/intel/gma/edid: Use unsigned type for count variable ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/38645/1/src/drivers/intel/gma/edid.... File src/drivers/intel/gma/edid.c:

https://review.coreboot.org/c/coreboot/+/38645/1/src/drivers/intel/gma/edid.... PS1, Line 68: unsigned int Why not u32, so as to hse the same type as edid_size?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38645 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I340a2752f955e5e4d2198a81408b3663b1488b80 Gerrit-Change-Number: 38645 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 30 Jan 2020 11:44:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

7:57 p.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38645 )

Change subject: drivers/intel/gma/edid: Use unsigned type for count variable ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38645 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I340a2752f955e5e4d2198a81408b3663b1488b80 Gerrit-Change-Number: 38645 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 30 Jan 2020 19:57:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

5 Feb 5 Feb

8:49 a.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38645 )

Change subject: drivers/intel/gma/edid: Use unsigned type for count variable ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38645/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38645/1//COMMIT_MSG@12 PS1, Line 12: .string "i" : .byte 0x1 : .byte 0x44 : - .byte 0x6 : - .long 0x4d : + .byte 0xf : + .long 0x60 : .long .LLST25 : .long .LVUS25 : .uleb128 0xe Is this debug info? I don't get it.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38645 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I340a2752f955e5e4d2198a81408b3663b1488b80 Gerrit-Change-Number: 38645 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Wed, 05 Feb 2020 08:49:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

4:47 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38645 )

Change subject: drivers/intel/gma/edid: Use unsigned type for count variable ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38645/1//COMMIT_MSG Commit Message:

...

Is this debug info? I don't get it.

It’s just to show, that the compiler is unable to take advantage of the more specific type information and generates the same code.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38645 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I340a2752f955e5e4d2198a81408b3663b1488b80 Gerrit-Change-Number: 38645 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Wed, 05 Feb 2020 16:47:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Nico Huber (Code Review)

5:32 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38645 )

Change subject: drivers/intel/gma/edid: Use unsigned type for count variable ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38645/1//COMMIT_MSG Commit Message:

...

It’s just to show, that the compiler is unable to take advantage of the more specific type informati […]

But you show a hunk of the diff here without context. Something changed and I don't understand what. What segment is this? does it end up in the final binary?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38645 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I340a2752f955e5e4d2198a81408b3663b1488b80 Gerrit-Change-Number: 38645 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Wed, 05 Feb 2020 17:32:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Martin L Roth (Code Review)

7 Aug 7 Aug

8:18 p.m.

New subject: [XS] Change in coreboot[master]: drivers/intel/gma/edid: Use unsigned type for count variable

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38645?usp=email )

Change subject: drivers/intel/gma/edid: Use unsigned type for count variable ......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38645?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I340a2752f955e5e4d2198a81408b3663b1488b80 Gerrit-Change-Number: 38645 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin L Roth gaumless@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-MessageType: abandon

290

days inactive

1575

days old

coreboot-gerrit@coreboot.org

6 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Martin L Roth (Code Review)
Nico Huber (Code Review)
Patrick Rudolph (Code Review)
Paul Menzel (Code Review)