Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56628 )
Change subject: arch/x86: Refactor the SMBIOS type 17 write function
......................................................................
Patch Set 11:
(4 comments)
File src/device/dram/spd.c:
https://review.coreboot.org/c/coreboot/+/56628/comment/47780440_80ac8068
PS11, Line 49: uint8_t
Why not use enum types instead of plain integer types? It's easy to forget which enum goes with which variable.
(Also applies to other cases like this in this patch)
https://review.coreboot.org/c/coreboot/+/56628/comment/ea295f19_d644cbe7
PS11, Line 171: sizeof(struct spd_info)
sizeof(*info)
https://review.coreboot.org/c/coreboot/+/56628/comment/69df4029_aae82748
PS11, Line 171: (struct spd_info *)
cast not needed
https://review.coreboot.org/c/coreboot/+/56628/comment/5cd8057e_30f4cfbc
PS11, Line 171: malloc
Why not let the caller pass a pointer to a `struct spd_info` instead? This way, there's no need to deal with dynamic memory in here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56628
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia337ac8f50b61ae78d86a07c7a86aa9c248bad50
Gerrit-Change-Number: 56628
Gerrit-PatchSet: 11
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 03 Sep 2021 12:43:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment