Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38960 )
Change subject: payloads/tianocore: Enable PS2 keyboard module ......................................................................
Patch Set 3:
(2 comments)
Should this be a Kconfig option so only boards with PS/2 controllers enable this? On the other hand, that might be too complex, and the default payload configuration in coreboot should be generic.
https://review.coreboot.org/c/coreboot/+/38960/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38960/3//COMMIT_MSG@9 PS3, Line 9: Upstream UEFIPayload now includes support for PS2 keyboards, but Could you please reference the upstream commit adding the support?
https://review.coreboot.org/c/coreboot/+/38960/3//COMMIT_MSG@11 PS3, Line 11: Please mention how much this increases the payload size.
-
Paul Menzel (Code Review)