Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39073 )
Change subject: mb/hp: Set CBFS_SIZE ......................................................................
mb/hp: Set CBFS_SIZE
Overwrite the default of 1 MiB with the actual bios regio size set in the stock IFD.
Allows to use payloads like tianocore without manually touching the CBFS_SIZE.
Change-Id: Ic1753a38212cc4961671fea11afe88265e73333b Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/mainboard/hp/compaq_8200_elite_sff/Kconfig M src/mainboard/hp/z220_sff_workstation/Kconfig 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/39073/1
diff --git a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig index e3b2ebd..6734d5b 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig +++ b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig @@ -19,6 +19,9 @@ select INTEL_GMA_HAVE_VBT select MAINBOARD_USES_IFD_GBE_REGION
+config CBFS_SIZE + default 0x2F0000 + config MAINBOARD_DIR string default "hp/compaq_8200_elite_sff" diff --git a/src/mainboard/hp/z220_sff_workstation/Kconfig b/src/mainboard/hp/z220_sff_workstation/Kconfig index dc288d6..8f28baf 100644 --- a/src/mainboard/hp/z220_sff_workstation/Kconfig +++ b/src/mainboard/hp/z220_sff_workstation/Kconfig @@ -30,6 +30,9 @@ hex default 0x2a
+config CBFS_SIZE + default 0x570000 + config MAINBOARD_DIR string default "hp/z220_sff_workstation"
Patrick Rudolph has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/39073 )
Change subject: mb/hp: Set CBFS_SIZE ......................................................................
mb/hp: Set CBFS_SIZE
Overwrite the default of 1 MiB with the actual bios region size set in the stock IFD.
Allows to use payloads like tianocore without manually touching the CBFS_SIZE.
Change-Id: Ic1753a38212cc4961671fea11afe88265e73333b Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/mainboard/hp/compaq_8200_elite_sff/Kconfig M src/mainboard/hp/z220_sff_workstation/Kconfig 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/39073/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39073 )
Change subject: mb/hp: Set CBFS_SIZE ......................................................................
Patch Set 2: Code-Review+2
Good idea
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39073 )
Change subject: mb/hp: Set CBFS_SIZE ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39073/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39073/2//COMMIT_MSG@12 PS2, Line 12: tianocore TianoCore
Patrick Georgi has uploaded a new patch set (#3) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/39073 )
Change subject: mb/hp: Set CBFS_SIZE ......................................................................
mb/hp: Set CBFS_SIZE
Overwrite the default of 1 MiB with the actual bios region size set in the stock IFD.
Allows to use payloads like TianoCore without manually touching the CBFS_SIZE.
Change-Id: Ic1753a38212cc4961671fea11afe88265e73333b Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/mainboard/hp/compaq_8200_elite_sff/Kconfig M src/mainboard/hp/z220_sff_workstation/Kconfig 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/39073/3
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39073 )
Change subject: mb/hp: Set CBFS_SIZE ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39073/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39073/2//COMMIT_MSG@12 PS2, Line 12: tianocore
TianoCore
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39073 )
Change subject: mb/hp: Set CBFS_SIZE ......................................................................
mb/hp: Set CBFS_SIZE
Overwrite the default of 1 MiB with the actual bios region size set in the stock IFD.
Allows to use payloads like TianoCore without manually touching the CBFS_SIZE.
Change-Id: Ic1753a38212cc4961671fea11afe88265e73333b Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39073 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/hp/compaq_8200_elite_sff/Kconfig M src/mainboard/hp/z220_sff_workstation/Kconfig 2 files changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig index e3b2ebd..6734d5b 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/Kconfig +++ b/src/mainboard/hp/compaq_8200_elite_sff/Kconfig @@ -19,6 +19,9 @@ select INTEL_GMA_HAVE_VBT select MAINBOARD_USES_IFD_GBE_REGION
+config CBFS_SIZE + default 0x2F0000 + config MAINBOARD_DIR string default "hp/compaq_8200_elite_sff" diff --git a/src/mainboard/hp/z220_sff_workstation/Kconfig b/src/mainboard/hp/z220_sff_workstation/Kconfig index dc288d6..8f28baf 100644 --- a/src/mainboard/hp/z220_sff_workstation/Kconfig +++ b/src/mainboard/hp/z220_sff_workstation/Kconfig @@ -30,6 +30,9 @@ hex default 0x2a
+config CBFS_SIZE + default 0x570000 + config MAINBOARD_DIR string default "hp/z220_sff_workstation"
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39073 )
Change subject: mb/hp: Set CBFS_SIZE ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/866 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/865 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/864
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)