Attention is currently required from: Jason Glenesk, Raul Rangel, Paul Menzel, Angel Pons.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51076 )
Change subject: soc/amd/cezanne: Disable legacy DMA IO ports
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51076/comment/6a3b09d0_7be77597
PS2, Line 10: ports.
ok
had a look and didn't find any mainboard that is compatible with the renoir/cezanne apus and still has a fdd connector. there are very few compatible or possibly compatible mainboards that still have a parallel port on an internal connector and since it can be operated in a mode that doesn't require the legacy isa dma to be present, i don't really expect this to break things. also the ports around 0x80 don't get decoded to the isa dma controller, so it's unclear it that has a chance to work with the default that doesn't decode those ports to isa dma
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51076
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7792d1f8ea40eb1c7f6cca67e9907208884ac694
Gerrit-Change-Number: 51076
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 02 Mar 2021 22:16:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment