Attention is currently required from: Martin Roth, Henry Sun, zanxi chen, Paul Menzel, Andy Yeh, Weimin Wu, ShawnX Tu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50995 )
Change subject: mb/google/dedede/var/storo: Add camera support
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Hi Karthik, […]
Even if camera EEPROM is going to be provisioned later, I would like SSFC in CBI to be provisioned now so that we can enable the MIPI camera for source value 1.
If we dont provision SSFC now, later when we add a second source we have to go add some unnnecessary code to handle the unprovisioned scenario.
I would rather prefer to spend some time now and than more time later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50995
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98d5708d1955406c2e46db972903057bb3d12dcc
Gerrit-Change-Number: 50995
Gerrit-PatchSet: 2
Gerrit-Owner: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Reviewer: Andy Yeh
andy.yeh@intel.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: ShawnX Tu
shawnx.tu@intel.com
Gerrit-Reviewer: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Andy Yeh
andy.yeh@intel.com
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Andy Yeh
andy.yeh@intel.com
Gerrit-Attention: ShawnX Tu
shawnx.tu@intel.com
Gerrit-Comment-Date: Tue, 02 Mar 2021 22:07:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Henry Sun
henrysun@google.com
Comment-In-Reply-To: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Comment-In-Reply-To: Andy Yeh
andy.yeh@intel.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment