Change in ...coreboot[master]: Revert "src/drivers/intel/wifi: Add a W/A for Intel ThP2 9260"

[Duncan Laurie (Code Review)]

Hello Patrick Rudolph, Aaron Durbin, Subrata Banik, Balaji Manigandan, Caveh Jalali, Rizwan Qureshi, Gaggery Tsai, build bot (Jenkins), Furquan Shaikh,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/31559

to review the following change.

Change subject: Revert "src/drivers/intel/wifi: Add a W/A for Intel ThP2 9260"
......................................................................

Revert "src/drivers/intel/wifi: Add a W/A for Intel ThP2 9260"

This reverts commit 3afb84a24583f5dee9fb407f11b32253d59392bf.

Reason for revert: This is causing issues with the PCIe link
and the system is unable to enter S0ix.  Until it can be fixed
in coreboot revert the change here that is not working properly.

BUG=b:124264120

Change-Id: Ia20da9ab560ca35950b4a916667f51e0f541b382
Signed-off-by: Duncan Laurie 
---
M src/drivers/intel/wifi/wifi.c
1 file changed, 0 insertions(+), 25 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/31559/1

diff --git a/src/drivers/intel/wifi/wifi.c b/src/drivers/intel/wifi/wifi.c
index 01a338d..e197114 100644
--- a/src/drivers/intel/wifi/wifi.c
+++ b/src/drivers/intel/wifi/wifi.c
@@ -255,34 +255,9 @@
 }
 #endif

-static void pci_dev_apply_quirks(struct device *dev)
-{
-	unsigned int cap;
-	uint16_t val;
-	struct device *root = dev->bus->dev;
-
-	switch (dev->device) {
-	case PCI_DEVICE_ID_TP_9260_SERIES_WIFI:
-		cap = pci_find_capability(root, PCI_CAP_ID_PCIE);
-		/* Check the LTR for root port and enable it */
-		if (cap) {
-			val = pci_read_config16(root, cap +
-				PCI_EXP_DEV_CAP2_OFFSET);
-			if (val & LTR_MECHANISM_SUPPORT) {
-				val = pci_read_config16(root, cap +
-					PCI_EXP_DEV_CTL_STS2_CAP_OFFSET);
-				val |= LTR_MECHANISM_EN;
-				pci_write_config16(root, cap +
-					PCI_EXP_DEV_CTL_STS2_CAP_OFFSET, val);
-			}
-		}
-	}
-}
-
 static void wifi_pci_dev_init(struct device *dev)
 {
    pci_dev_init(dev);
-	pci_dev_apply_quirks(dev);

if (IS_ENABLED(CONFIG_ELOG)) {
    	uint32_t val;

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31559 )

Change subject: Revert "src/drivers/intel/wifi: Add a W/A for Intel ThP2 9260"
......................................................................

Patch Set 1: Code-Review+2

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31559 )

Change subject: Revert "src/drivers/intel/wifi: Add a W/A for Intel ThP2 9260"
......................................................................

Patch Set 1: Code-Review+1

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31559 )

Change subject: Revert "src/drivers/intel/wifi: Add a W/A for Intel ThP2 9260"
......................................................................

Patch Set 1: Code-Review+2

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31559 )

Change subject: Revert "src/drivers/intel/wifi: Add a W/A for Intel ThP2 9260"
......................................................................

Patch Set 1: Code-Review+2

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31559 )

Change subject: Revert "src/drivers/intel/wifi: Add a W/A for Intel ThP2 9260"
......................................................................

Patch Set 1:

submitting so we can unblock testing.

[Duncan Laurie (Code Review)]

Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31559 )

Change subject: Revert "src/drivers/intel/wifi: Add a W/A for Intel ThP2 9260"
......................................................................

Revert "src/drivers/intel/wifi: Add a W/A for Intel ThP2 9260"

This reverts commit 3afb84a24583f5dee9fb407f11b32253d59392bf.

Reason for revert: This is causing issues with the PCIe link
and the system is unable to enter S0ix.  Until it can be fixed
in coreboot revert the change here that is not working properly.

BUG=b:124264120

Change-Id: Ia20da9ab560ca35950b4a916667f51e0f541b382
Signed-off-by: Duncan Laurie 
Reviewed-on: https://review.coreboot.org/c/31559
Reviewed-by: Aaron Durbin 
Reviewed-by: Caveh Jalali 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Subrata Banik 
Tested-by: build bot (Jenkins) 
---
M src/drivers/intel/wifi/wifi.c
1 file changed, 0 insertions(+), 25 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved
  Furquan Shaikh: Looks good to me, approved
  Subrata Banik: Looks good to me, approved
  Caveh Jalali: Looks good to me, but someone else must approve

diff --git a/src/drivers/intel/wifi/wifi.c b/src/drivers/intel/wifi/wifi.c
index 416b04b..ade5087 100644
--- a/src/drivers/intel/wifi/wifi.c
+++ b/src/drivers/intel/wifi/wifi.c
@@ -255,34 +255,9 @@
 }
 #endif

-static void pci_dev_apply_quirks(struct device *dev)
-{
-	unsigned int cap;
-	uint16_t val;
-	struct device *root = dev->bus->dev;
-
-	switch (dev->device) {
-	case PCI_DEVICE_ID_TP_9260_SERIES_WIFI:
-		cap = pci_find_capability(root, PCI_CAP_ID_PCIE);
-		/* Check the LTR for root port and enable it */
-		if (cap) {
-			val = pci_read_config16(root, cap +
-				PCI_EXP_DEV_CAP2_OFFSET);
-			if (val & LTR_MECHANISM_SUPPORT) {
-				val = pci_read_config16(root, cap +
-					PCI_EXP_DEV_CTL_STS2_CAP_OFFSET);
-				val |= LTR_MECHANISM_EN;
-				pci_write_config16(root, cap +
-					PCI_EXP_DEV_CTL_STS2_CAP_OFFSET, val);
-			}
-		}
-	}
-}
-
 static void wifi_pci_dev_init(struct device *dev)
 {
    pci_dev_init(dev);
-	pci_dev_apply_quirks(dev);

if (IS_ENABLED(CONFIG_ELOG)) {
    	uint32_t val;