Duncan Laurie would like Patrick Rudolph, Aaron Durbin, Subrata Banik, Balaji Manigandan, Caveh Jalali, Rizwan Qureshi, Gaggery Tsai, build bot (Jenkins) and Furquan Shaikh to review this change.

View Change

Revert "src/drivers/intel/wifi: Add a W/A for Intel ThP2 9260"

This reverts commit 3afb84a24583f5dee9fb407f11b32253d59392bf.

Reason for revert: This is causing issues with the PCIe link
and the system is unable to enter S0ix. Until it can be fixed
in coreboot revert the change here that is not working properly.

BUG=b:124264120

Change-Id: Ia20da9ab560ca35950b4a916667f51e0f541b382
Signed-off-by: Duncan Laurie <dlaurie@google.com>
---
M src/drivers/intel/wifi/wifi.c
1 file changed, 0 insertions(+), 25 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/31559/1
diff --git a/src/drivers/intel/wifi/wifi.c b/src/drivers/intel/wifi/wifi.c
index 01a338d..e197114 100644
--- a/src/drivers/intel/wifi/wifi.c
+++ b/src/drivers/intel/wifi/wifi.c
@@ -255,34 +255,9 @@
}
#endif

-static void pci_dev_apply_quirks(struct device *dev)
-{
- unsigned int cap;
- uint16_t val;
- struct device *root = dev->bus->dev;
-
- switch (dev->device) {
- case PCI_DEVICE_ID_TP_9260_SERIES_WIFI:
- cap = pci_find_capability(root, PCI_CAP_ID_PCIE);
- /* Check the LTR for root port and enable it */
- if (cap) {
- val = pci_read_config16(root, cap +
- PCI_EXP_DEV_CAP2_OFFSET);
- if (val & LTR_MECHANISM_SUPPORT) {
- val = pci_read_config16(root, cap +
- PCI_EXP_DEV_CTL_STS2_CAP_OFFSET);
- val |= LTR_MECHANISM_EN;
- pci_write_config16(root, cap +
- PCI_EXP_DEV_CTL_STS2_CAP_OFFSET, val);
- }
- }
- }
-}
-
static void wifi_pci_dev_init(struct device *dev)
{
pci_dev_init(dev);
- pci_dev_apply_quirks(dev);

if (IS_ENABLED(CONFIG_ELOG)) {
uint32_t val;

To view, visit change 31559. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia20da9ab560ca35950b4a916667f51e0f541b382
Gerrit-Change-Number: 31559
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan@intel.com>
Gerrit-Reviewer: Caveh Jalali <caveh@google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai@intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: newchange