Scott Collyer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31537
Change subject: hatch: Make EC software sync enabled by default ......................................................................
hatch: Make EC software sync enabled by default
EC software sync had been disabled because BIOS was not bundling a useful EC image. This is no longer required. This CL removes that change so EC software sync is enabled by default.
BUG=b:124208414 BRANCH=None TEST=Tested with a system that have a different RW image and verified that this image was overwritten to the one bundled in the BIOS and that the EC was running its RW image.
Signed-off-by: Scott Collyer scollyer@chromium.org Change-Id: Ic1ffdb62e9fa2cacb3296cb3807082f23e171ab5 --- M src/mainboard/google/hatch/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/31537/1
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 65a3562..b97977c 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -27,7 +27,6 @@ select GBB_FLAG_FORCE_DEV_BOOT_USB select GBB_FLAG_FORCE_DEV_BOOT_LEGACY select GBB_FLAG_FORCE_MANUAL_RECOVERY - select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC select HAS_RECOVERY_MRC_CACHE select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN select VBOOT_LID_SWITCH
Scott Collyer has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/31537 )
Change subject: mb/google/hatch: Make EC software sync enabled by default ......................................................................
mb/google/hatch: Make EC software sync enabled by default
EC software sync had been disabled because BIOS was not bundling a useful EC image. This is no longer required. This CL removes that change so EC software sync is enabled by default.
BUG=b:124208414 BRANCH=None TEST=Tested with a system that have a different RW image and verified that this image was overwritten to the one bundled in the BIOS and that the EC was running its RW image.
Signed-off-by: Scott Collyer scollyer@chromium.org Change-Id: Ic1ffdb62e9fa2cacb3296cb3807082f23e171ab5 --- M src/mainboard/google/hatch/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/31537/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31537 )
Change subject: mb/google/hatch: Make EC software sync enabled by default ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31537 )
Change subject: mb/google/hatch: Make EC software sync enabled by default ......................................................................
mb/google/hatch: Make EC software sync enabled by default
EC software sync had been disabled because BIOS was not bundling a useful EC image. This is no longer required. This CL removes that change so EC software sync is enabled by default.
BUG=b:124208414 BRANCH=None TEST=Tested with a system that have a different RW image and verified that this image was overwritten to the one bundled in the BIOS and that the EC was running its RW image.
Signed-off-by: Scott Collyer scollyer@chromium.org Change-Id: Ic1ffdb62e9fa2cacb3296cb3807082f23e171ab5 Reviewed-on: https://review.coreboot.org/c/31537 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 65a3562..b97977c 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -27,7 +27,6 @@ select GBB_FLAG_FORCE_DEV_BOOT_USB select GBB_FLAG_FORCE_DEV_BOOT_LEGACY select GBB_FLAG_FORCE_MANUAL_RECOVERY - select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC select HAS_RECOVERY_MRC_CACHE select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN select VBOOT_LID_SWITCH
-
Furquan Shaikh (Code Review) -
Scott Collyer (Code Review)