Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Karthik Ramasubramanian.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62387 )
Change subject: util/spd_tools: Encode SDRAM min cycle time (TCKMinPs)
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Patchset:
PS2:
(+1 only because I don't have +2 permissions yet)
File util/spd_tools/src/spd_gen/lp5.go:
https://review.coreboot.org/c/coreboot/+/62387/comment/4eedc969_0c02dab0
PS1, Line 587: if ok == false || tCKMinPs == 0 {
: return LP5GetDefaultTCKMinPs(memAttribs)
: }
I defined the default speed to TCKMinPs mapping inside the earlier table. […]
Thanks! This is nicer than what I suggested :)
File util/spd_tools/src/spd_gen/lp5.go:
https://review.coreboot.org/c/coreboot/+/62387/comment/df9f7606_6f4095e0
PS2, Line 573: Println
nit: Println() doesn't support format specifiers. Can you change it to Printf() and add a \n
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62387
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I99ada7ead3a75befb0f934af871eecc060adcb26
Gerrit-Change-Number: 62387
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 03 Mar 2022 22:23:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment