Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Karthik Ramasubramanian.

Patch set 2:Code-Review +1

View Change

3 comments:

• Patchset:

  • Patch Set #2:

    (+1 only because I don't have +2 permissions yet)

• File util/spd_tools/src/spd_gen/lp5.go:

  • Patch Set #1, Line 587:

    if ok == false || tCKMinPs == 0 {
    		return LP5GetDefaultTCKMinPs(memAttribs)
    	}
    

    I defined the default speed to TCKMinPs mapping inside the earlier table. […]

    Thanks! This is nicer than what I suggested :)

• File util/spd_tools/src/spd_gen/lp5.go:

  • Patch Set #2, Line 573: Println

    nit: Println() doesn't support format specifiers. Can you change it to Printf() and add a \n

To view, visit change 62387. To unsubscribe, or for help writing mail filters, visit settings.