nsekar@codeaurora.org has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32108
Change subject: qcs405: Update memory layout ......................................................................
qcs405: Update memory layout
Update the memory layout so that we get to use the unused space. This enables us to use default kernel size of 512 MB configuration in depthcharge.
Change-Id: I419bfefadb610c3fdf2b8ed56965801be0dc4e90 Signed-off-by: Nitheesh Sekar nsekar@codeaurora.org --- M src/soc/qualcomm/qcs405/include/soc/memlayout.ld 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/32108/1
diff --git a/src/soc/qualcomm/qcs405/include/soc/memlayout.ld b/src/soc/qualcomm/qcs405/include/soc/memlayout.ld index 68642d6..6856919 100644 --- a/src/soc/qualcomm/qcs405/include/soc/memlayout.ld +++ b/src/soc/qualcomm/qcs405/include/soc/memlayout.ld @@ -45,6 +45,6 @@ DRAM_START(0x80000000) /* DDR Carveout for BL31 usage */ REGION(dram_reserved, 0x85000000, 0x5100000, 4096) - POSTRAM_CBFS_CACHE(0x9F800000, 384K) - RAMSTAGE(0x9F860000, 128K) + POSTRAM_CBFS_CACHE(0x8A100000, 384K) + RAMSTAGE(0x8A160000, 128K) }
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32108 )
Change subject: qcs405: Update memory layout ......................................................................
Patch Set 1:
There's nothing wrong with this but it shouldn't be necessary. The kernel buffer in depthcharge only starts being used *after* depthcharge is entered, at which point both the ramstage and cbfs_cache from coreboot are no longer used. So it should not be a problem to overlap them. The only thing you need to watch out for is that the depthcharge program itself (i.e. what comes after CONFIG_BASE_ADDRESS) doesn't overlap with those regions.
Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32108 )
Change subject: qcs405: Update memory layout ......................................................................
Abandoned
won't be finished here
-
Julius Werner (Code Review) -
Name of user not set (Code Review)
-
Patrick Georgi (Code Review)