There's nothing wrong with this but it shouldn't be necessary. The kernel buffer in depthcharge only starts being used *after* depthcharge is entered, at which point both the ramstage and cbfs_cache from coreboot are no longer used. So it should not be a problem to overlap them. The only thing you need to watch out for is that the depthcharge program itself (i.e. what comes after CONFIG_BASE_ADDRESS) doesn't overlap with those regions.

View Change

To view, visit change 32108. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I419bfefadb610c3fdf2b8ed56965801be0dc4e90
Gerrit-Change-Number: 32108
Gerrit-PatchSet: 1
Gerrit-Owner: nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: nsekar@codeaurora.org
Gerrit-Comment-Date: Thu, 28 Mar 2019 20:04:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment